[LU-19957] __ll_page_mkwrite() redundant check

• Type: Bug
• Resolution: Unresolved
• Priority: Trivial
• Labels: easy
• Severity: 3
• Assignee: WC Triage
• Reporter: Oleg Drokin

Description

smatch highlights this:

         if (result == 0) {
                lock_page(vmpage);
                if (vmpage->mapping == NULL) {
                        unlock_page(vmpage);
                        /* page was truncated and lock was cancelled, return
                         * ENODATA so that VM_FAULT_NOPAGE will be returned
                         * to handle_mm_fault().
                         */
                        if (result == 0)
                                result = -ENODATA;

the result is checked twice for no reason.

The problem introduced by this patch: http://review.whamcloud.com/5222