[LU-20272] NULL deref of out_clean_llog_fileset in nodemap_del()

• Type: Bug
• Resolution: Unresolved
• Priority: Minor
• Severity: 3
• Assignee: WC Triage
• Reporter: Sohei Koyama

Description

In nodemap_del() around line 4364, there's this check:

if (fileset_prim_exists && !rc && !nodemap->nmf_fileset_use_iam &&
  !nodemap->nm_dyn)
  *out_clean_llog_fileset = true;

But nodemap_del() is called with NULL for that param at line 4311 (nodemap_del(nm->nm_name, NULL)). The other two spots in the same function do guard with && out_clean_llog_fileset before dereferencing, so it looks like this one just got missed?

 

Discovered by code inspect.