Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-20279

Build scripts don't copy ext4/crypto.c if EXT4_CRYPTO is not set

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Medium
    • Lustre 2.18.0
    • Lustre 2.18.0
    • None
    • 3
    • 9223372036854775807

    Description

      Looks like when EXT4_CRYPTO is not set, we do not copy fs/ext4/crypto.c for ldiskfs and then whatever patch might need it - fails to apply.

      This was exposed by this patch in particular: https://review.whamcloud.com/c/fs/lustre-release/+/65426

      config/lustre-build-ldiskfs.m4:

                      LB2_TEST_CHECK_CONFIG_IM([FS_ENCRYPTION], [
                              EXT4_CRYPTO=],[
                              EXT4_CRYPTO='%/crypto.c'])
                      LB2_TEST_CHECK_CONFIG_IM([FS_VERITY], [
                              EXT4_VERITY=],[
                              EXT4_VERITY='%/verity.c'])
      

      ldiskfs/Makefile.in:

      backfs_sources := $(filter-out %.mod.c $(backfs_unit_tests) @EXT4_CRYPTO@ @EXT4_VERITY@,$(wildcard @EXT4_SRC_DIR@/*.c)) 

      Looks like similar problem is with verity?

      Attachments

        Activity

          People

            shadow Alexey Lyashkov
            green Oleg Drokin
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated: