Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-20429

contrib: accept 'Assisted-by:' tag in checkpatch and commit-msg hook

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • Lustre 2.18.0
    • None
    • None
    • 3
    • 9223372036854775807

      As documented in the Lustre wiki, commits with significant AI assistance should be properly attributed with the 'Assisted-By:' tag:

      https://wiki.lustre.org/Commit_Comments#AI/LLM/Tool_Attribution 

      Currently the commit-msg git hook does not accept such a tag:

      $ git commit --amend                                                                                                                                                                                 
line 38: Assisted-by: Claude:claude-opus-4-8                                                                                                
error: commit message invalid signoff section line

      similarly, the checkpatch.pl script also errors on this:

      $ git format-patch -1 --stdout | perl contrib/scripts/checkpatch.pl -
WARNING: Non-standard signature: Assisted-by:
#41: 
Assisted-by: Claude:claude-opus-4-8

ERROR: Unrecognized email address: 'Claude:claude-opus-4-8'
#41: 
Assisted-by: Claude:claude-opus-4-8

total: 1 errors, 1 warnings, 74 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH] LU-20377 mgs: list sptlrpc and params logs in llog_catlist" has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

            mrasobarnett Matt Rásó-Barnett
            mrasobarnett Matt Rásó-Barnett
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: