Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-2053

Significant memory leak in new crypto code

Details

    • Bug
    • Resolution: Fixed
    • Blocker
    • Lustre 2.3.0, Lustre 2.4.0
    • Lustre 2.3.0, Lustre 2.4.0
    • None
    • 3
    • 4295

    Description

      The new cryptoapi code introduced a memory allocation in cfs_crypto_hash_init for hdesc that's never freed anywhere other than on error path in cfs_crypto_hash_init itself.

      Attachments

        Activity

          [LU-2053] Significant memory leak in new crypto code
          green Oleg Drokin added a comment -

          LAnded to b2_3 and cherrypicked to master

          green Oleg Drokin added a comment - LAnded to b2_3 and cherrypicked to master
          green Oleg Drokin added a comment -

          Right, I had the same wrong assumption as you.
          Though my (very limited) testing with leak tracing enabled did not find anything else.

          green Oleg Drokin added a comment - Right, I had the same wrong assumption as you. Though my (very limited) testing with leak tracing enabled did not find anything else.

          Strangely, I thought that cfs_alloc() has memory leak tracing, but it seems this is only true of OBD_ALLOC(). That means there is a real possibility of other memory leaks existing that we do not know about.

          adilger Andreas Dilger added a comment - Strangely, I thought that cfs_alloc() has memory leak tracing, but it seems this is only true of OBD_ALLOC(). That means there is a real possibility of other memory leaks existing that we do not know about.
          green Oleg Drokin added a comment -

          http://review.whamcloud.com/4135 is b2_3 version of the fix

          green Oleg Drokin added a comment - http://review.whamcloud.com/4135 is b2_3 version of the fix

          People

            green Oleg Drokin
            green Oleg Drokin
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: