Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-20552

MDD: mdd_lmm_oi/gen ignore LOV_MAGIC_SEL and LOV_MAGIC_DEFINED

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Medium Medium
    • None
    • None
    • None
    • 3
    • 9223372036854775807

      During work on LU-20534 an unrelated issue in dependent code was found.

      mdd_lmm_oi() and mdd_lmm_gen() only matched LOV_MAGIC_COMP_V1 .

      SEL: Layouts with extension components use LOV_MAGIC_SEL (same composite blob as COMP_V1). During MDT migrate, mdd_xattrs_migrate_prep() calls mdd_set_lmm_oi() ; with SEL that was a no-op, so the LOV kept the old MDT FID in lmm_oi .

      DEFINED: When swap applies a layout onto a layout-less file, mdd_swap_layouts() ORs LOV_MAGIC_DEFINED on the incoming LOV before mdd_set_lmm_gen() . The gen helper did not mask that bit, so generation updates failed. ( mdd_lmm_oi() callers never pass DEFINED; masking there is for symmetry only.)

      Fix: Treat LOV_MAGIC_SEL like COMP_V1; mask LOV_MAGIC_DEFINED when matching magic.

            rsahlberg@whamcloud.com Ronnie Sahlberg
            rsahlberg@whamcloud.com Ronnie Sahlberg
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: