test_123aj fails in cleanup, not in the test body:
cleanup test 123aj
onyx-141vm39: error: executing set_param: No such file or directory
test_123aj returned 2

cleanup_123aj() in lustre/tests/conf-sanity.sh ends with:
do_nodes $(osts_nodes) "$LCTL set_param ${svc}.nrs_policies=fifo"
with no '|| true', unlike the two set_param calls immediately above it in the same function. On this cluster (2 OSS, 16 OSTs, 8 per OSS) 'ost.OSS.ost_io.nrs_policies' was not available on one of the two OSS nodes at cleanup time, so that do_nodes call returned non-zero; the stack_trap handler propagated that as the test's own return code, and test_123aj was marked FAIL even though the test body itself completed successfully.

Not this patch's: osts_nodes() and facets_nodes() return the same comma-separated, sorted, unique set of active OST hosts before and after the diff under review (the diff only changes how that string is assembled internally, e.g. moving the comma-join inside facets_nodes(), not its content), and cleanup_123aj() itself is untouched by the diff.

Maloo: https://testing.whamcloud.com/test_sets/12b03951-22b4-42bd-bca0-7b0147c3eafc (test_123aj)

Raised by Patch Watcher run pw-engineer-51976-ps6-684d26660414 on https://review.whamcloud.com/51976