Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-20462 Lustre Find Utility (LFU)
  3. LU-21206

LFU: keep the scan API private for 2.18

XMLWordPrintable

    • Icon: Technical task Technical task
    • Resolution: Unresolved
    • Icon: Medium Medium
    • Lustre 2.18.0
    • None
    • None
    • 3
    • 9223372036854775807

      2.18.x is a long-term support release, so every public interface added in 2.18 has to be kept for years. The LFU changes for 2.18 currently add seven public functions to liblustreapi, each with a man page:

      • llapi_scan_namespace() (landed in 2.17.5x, LU-20603)
      • llapi_scan_device(), llapi_find_device() (LU-20611)
      • llapi_scan_rec_path() (LU-20637)
      • llapi_scan_changelog(), llapi_scan_fid() (LU-20649), llapi_find_since() (LU-20650)

      lfs find needs only one interface, llapi_find() with struct find_param, which predates 2.18. The one new public scan interface in 2.18 should be the LFU Object Stream (LU-20730, llapi_lfu_*()), so that tools such as lfu-purge and lfu-resync do not start on a per-object interface that is then replaced.

      Plan, after the 2.18 LFU changes land and before 2.18.0:

      • llapi_find() reads a target when fp_device is set, and the changelog when fp_since_kind, fp_changelog_mdt or fp_since_cookie is set; otherwise it walks as today. lfs find calls only llapi_find(), and the --bookmark file is read and written by the library.
      • The seven functions become internal (renamed, declared in an internal header, not exported by liblustreapi.so); their man pages are removed, and llapi_find.3 describes the new find_param fields.
      • The scan tests reach the internal functions through a convenience library, so they still build with --disable-static.

      Nothing visible to lfs find users changes. A prototype passes conf-sanity 300a-306 and sanity 56Ee, 56Eea and 160Aa-160Af.

            hnishida Hiroshi Nishida
            hnishida Hiroshi Nishida
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: