[LU-2241] symlink bug in 2.3.0

• Type: Bug
• Resolution: Fixed
• Priority: Critical
• Fix Version/s: Lustre 2.4.0
• Affects Version/s: Lustre 2.3.0
• Environment: RHEL6.3
• Severity: 3

Epic

metadata server

• Assignee: Nathaniel Clark
• Reporter: Wolfgang Baudler

Description

Symlinks with a destination path that has the exact length of 61 characters don't work.

For example

$ ln -s 123456789012345678901234567890123456789012345678901234567890
$ ls -al
ls: cannot read symbolic link 123456789012345678901234567890123456789012345678901234567890: Protocol error

Symlinks with shorter or longer paths work fine. I assume an off-by-one error, since 60 characters seems to be the limit for storing the symlink inside of an inode.

Lustre 2.2.0 did not have this problem.

Issue Links

• is duplicated by: LU-2405 Interop 2.3<->2.4 Failure on test suite sanity, test_17g: symlink not NULL terminated stringof length 60

Comments

[Nathaniel Clark]

b2_1 version of this patch submitted to fix LU-2405
http://review.whamcloud.com/4711

[Nathaniel Clark]

Change has been successfully cherry-picked as 6c3606b79a4c25946255a680f79ff2d58df66bbc

[Keith Mannthey (Inactive)]

Thanks for adding a test to sanity.sh.

[Nathaniel Clark]

http://review.whamcloud.com/4415

Since this is a server only issue, The client code doesn't need to be patched, I believe this only affects master.

[Nathaniel Clark]

Reproduced with MDS/MGS/OSS servers 2.3.54

The following client versions exhibited this issue:

• 2.3.54
• 1.8.8.60

[Wolfgang Baudler]

Client logs this when such a symlink is accessed:

kernel: LustreError: 11096:0:(symlink.c:95:ll_readlink_internal()) inode 144115574354477068: symlink not NULL terminated stringof length 60