[LU-2311] clean up MDD orphan handling code style

• Type: Improvement
• Resolution: Duplicate
• Priority: Minor
• Affects Version/s: Lustre 2.4.0
• Labels: easy
• Assignee: Andreas Dilger
• Reporter: Andreas Dilger

Description

Clean up the code style of the MDD orphan handling, since there are numerous extraneous wrapper functions and abstractions that do not improve the code readability, and functions that are used outside of mdd_orphan.c should keep the mdd_ prefix for consistency.

Also the orphan nlink handling in osd_object_ref_{add,del}(), which is based on ldiskfs_{inc,dec}_link(), is missing a fix compared to the upstream kernel, and is implemented in a manner that is more complex than needed.

Issue Links

• is related to: LU-3022 osd_handler.c:2534:osd_object_ref_del()) ASSERTION( inode->i_nlink > 0 ) failed
• is related to: LU-7787 There is space in the middle of filename under PENDING