Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-2484

md_stats not used or used incorrectly

Details

    • 5826

    Description

      The stats maintained by the EXP_MD_COUNTER_INCREMENT in the md_ops member wrappers and stored in struct obd_device's md_stats are not used. The classes that implement the the md_ops interface (lmv and mdc) do not allocate the them and the classes that allocate them (mgs and mdt) do not implement md_ops. (This is not a terrible issue but it does add to the internal and external cognitive crud of lustre proc.)

      It should be easy to add these stats to lmv and mds but the value of doing so seems low. md_ops contains several groups of low-level function whose counts would be highly correlated and there are already counters in llite for the high level metadata operations.

      If they are to be enabled anywhere then EXP_MD_COUNTER_INCREMENT() should check exp->exp_obd->md_stats rather than exp->exp_obd->obd_stats; lprocfs_alloc_md_stats() should check that obd->obd_type->typ_md_ops is not NULL; and exp_md_stats should be used somewhere or removed.

      Attachments

        Activity

          [LU-2484] md_stats not used or used incorrectly
          jlevi Jodi Levi (Inactive) made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Reopened [ 4 ] New: Resolved [ 5 ]

          Added 2.5.0 FixVersion

          jlevi Jodi Levi (Inactive) added a comment - Added 2.5.0 FixVersion
          jlevi Jodi Levi (Inactive) made changes -
          Fix Version/s New: Lustre 2.5.0 [ 10295 ]
          jlevi Jodi Levi (Inactive) made changes -
          Resolution Original: Fixed [ 1 ]
          Status Original: Closed [ 6 ] New: Reopened [ 4 ]
          jhammond John Hammond made changes -
          Status Original: Resolved [ 5 ] New: Closed [ 6 ]
          jhammond John Hammond made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]

          Patch landed to master.

          jhammond John Hammond added a comment - Patch landed to master.
          jhammond John Hammond added a comment -

          Keith, this data is well used by admins. The big sites support a healthy cottage industry of lustre monitoring tools.

          jhammond John Hammond added a comment - Keith, this data is well used by admins. The big sites support a healthy cottage industry of lustre monitoring tools.

          Have we thought about moving part of this stat data to a perf tracepoints sort of implementation with the idea to keep admin friendly items in /proc and developer data elsewhere?

          keith Keith Mannthey (Inactive) added a comment - Have we thought about moving part of this stat data to a perf tracepoints sort of implementation with the idea to keep admin friendly items in /proc and developer data elsewhere?
          jhammond John Hammond made changes -
          Assignee Original: Keith Mannthey [ keith ] New: John Hammond [ jhammond ]

          People

            jhammond John Hammond
            jhammond John Hammond
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: