Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-2639

make lod_sync() more robust

Details

    • Bug
    • Resolution: Unresolved
    • Minor
    • None
    • Lustre 2.4.0
    • 3
    • 6173

    Description

      Per inspection in http://review.whamcloud.com/4921, lod_sync() should call dt_sync() on all targets, even if some sub-targets return an error. Also, it should call dt_sync() on all MDT targets as well as OST targets.

      Attachments

        Activity

          [LU-2639] make lod_sync() more robust
          gerrit Gerrit Updater added a comment -

          "Aryan Gupta <argupta@ddn.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/59658
          Subject: LU-2639 lod: preserve first error in lod_sync()
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: cb9fa954e41c47435a547fbb61b3b08973b42fb3

          gerrit Gerrit Updater added a comment - "Aryan Gupta <argupta@ddn.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/59658 Subject: LU-2639 lod: preserve first error in lod_sync() Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: cb9fa954e41c47435a547fbb61b3b08973b42fb3
          adilger Andreas Dilger added a comment -

          argupta, could you please take a look at this one also. It is quite straight forward:

          • remove "break" from the lod_sync() loops
          • use "rc2" to save the dt_sync() return
          • save the first non-zero rc2 error code that is hit into rc
          adilger Andreas Dilger added a comment - argupta , could you please take a look at this one also. It is quite straight forward: remove " break " from the lod_sync() loops use " rc2 " to save the dt_sync() return save the first non-zero rc2 error code that is hit into rc
          adilger Andreas Dilger added a comment -

          This is still an issue.

          adilger Andreas Dilger added a comment - This is still an issue.
          simmonsja James A Simmons added a comment -

          This patch has been merged to master. Can this ticket be closed?

          simmonsja James A Simmons added a comment - This patch has been merged to master. Can this ticket be closed?

          People

            argupta Aryan Gupta
            adilger Andreas Dilger
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated: