[LU-2673] lprocfs_free_obd_stats() must follow lprocfs_obd_cleanup()

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.4.0
• Affects Version/s: Lustre 2.4.0
• Labels: ofd procfs
• Severity: 3
• Assignee: Keith Mannthey (Inactive)
• Reporter: John Hammond

Description

# llmount.sh
...
# exec 4>/proc/fs/lustre/obdfilter/lustre-OST0000/stats
# while true; do echo >&4; done &
# umount /mnt/ost1

general protection fault: 0000 [#1] SMP 
last sysfs file: /sys/devices/virtual/block/loop1/range
CPU 1 
Modules linked in: lustre(U) ofd(U) osp(U) lod(U) ost(U) mdt(U) osd_ldiskfs(U) fsfilt_ldiskfs(U) ldiskfs(U) exportfs mdd(U) mgs(U) lquota(U) jbd obdecho(U) mgc(U) lov(U) osc(U) mdc(U) lmv(U) fid(U) fld(U) ptlrpc(U) obdclass(U) lvfs(U) ksocklnd(U) lnet(U) sha512_generic sha256_generic libcfs(U) autofs4 nfs lockd fscache nfs_acl auth_rpcgss sunrpc ipv6 zfs(P)(U) zcommon(P)(U) znvpair(P)(U) zavl(P)(U) zunicode(P)(U) spl(U) zlib_deflate microcode virtio_balloon virtio_net i2c_piix4 i2c_core ext4 mbcache jbd2 virtio_blk virtio_pci virtio_ring virtio pata_acpi ata_generic ata_piix dm_mirror dm_region_hash dm_log dm_mod [last unloaded: speedstep_lib]

Pid: 1755, comm: bash Tainted: P           ---------------    2.6.32-279.14.1.el6_lustre_gcov.x86_64 #10 Bochs Bochs
RIP: 0010:[<ffffffffa06aeccc>]  [<ffffffffa06aeccc>] lprocfs_clear_stats+0x7c/0x110 [obdclass]
RSP: 0018:ffff880200e81e68  EFLAGS: 00010202
RAX: 0000000000000000 RBX: ffff8801b11af340 RCX: 0000000000000001
RDX: 5a5a5a5a5a5a5a5a RSI: 00007f6db3330000 RDI: 5a5a5a5a5a5a5a5a
RBP: ffff880200e81e78 R08: 0000000000000002 R09: 0000000000000000
R10: 0000000000005a5a R11: 7fffffffffffffff R12: ffff880219668900
R13: 00007f6db3330000 R14: 0000000000000001 R15: fffffffffffffffb
FS:  00007f6db3328700(0000) GS:ffff880028280000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000003282f53fe3 CR3: 000000020087f000 CR4: 00000000000006e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
Process bash (pid: 1755, threadinfo ffff880200e80000, task ffff8801ff155540)
Stack:
 ffff880200e80000 0000000000000001 ffff880200e81e98 ffffffffa06aed81
<d> ffff8802034a1d80 ffff8802034a1d80 ffff880200e81ee8 ffffffff811e273e
<d> ffff880200e81eb8 ffff880200e81f48 ffff880200e81ee8 ffff880219668900
Call Trace:
 [<ffffffffa06aed81>] lprocfs_stats_seq_write+0x21/0x30 [obdclass]
 [<ffffffff811e273e>] proc_reg_write+0x7e/0xc0
 [<ffffffff8117cc98>] vfs_write+0xb8/0x1a0
 [<ffffffff810d6d42>] ? audit_syscall_entry+0x272/0x2a0
 [<ffffffff8117d6b1>] sys_write+0x51/0x90
 [<ffffffff8100b0f2>] system_call_fastpath+0x16/0x1b
Code: 83 3b 00 74 51 31 c9 eb 0a 66 0f 1f 44 00 00 4a 8b 3c c3 48 63 d1 49 bb ff ff ff ff ff ff ff 7f 83 c1 01 48 8d 14 d2 48 8d 14 d7 <48> c7 42 08 00 00 00 00 48 c7 42 10 00 00 00 00 4c 89 5a 20 48 
RIP  [<ffffffffa06aeccc>] lprocfs_clear_stats+0x7c/0x110 [obdclass]
 RSP <ffff880200e81e68>

Issue Links

• is duplicated by: LU-2648 8 timout issues in a test run and incomplete logs.