[LU-2682] clean up direct _id and _seq access, use ost_id everywhere

• Type: Technical task
• Resolution: Fixed
• Priority: Major
• Fix Version/s: Lustre 2.4.0
• Affects Version/s: Lustre 2.4.0
• Assignee: Di Wang
• Reporter: Andreas Dilger

Description

There are a number of cleanups that should be done for the ost_id members of various structures.

Access/copying the individual _id and _seq fields should be replaced with the _oi field, and compatibility macros for accessing the individual fields should be removed.

POID/DOID macros should be introduced to print out the _oi fields, similar to PFID/DFID is used for lu_fid fields. Johann had a patch for doing some of this in http://review.whamcloud.com/2004 that needs to be refreshed and resubmitted.

Issue Links

• is related to: LU-2684 convert ost_id to lu_fid for FID_SEQ_NORMAL objects

Comments

[Peter Jones]

Landed for 2.4

[Di Wang]

http://review.whamcloud.com/5601

[Andreas Dilger]

Di, I still see a lot of code like:

        oa->o_id = lsm->lsm_object_id;
        oa->o_seq = lsm->lsm_object_seq;

that should be replaced with:

        oa->o_oi = lsm->lsm_object_oid;

also, lsm_object_oid should be renamed lsm_oi or lsm_ostid so that it is not confused with f_oid.

[Andreas Dilger]

As part of this ost_id cleanup patch, please rename lsm_object_oid to lsm_oi or lsm_ostid, if it hasn't been done through a refresh of http://review.whamcloud.com/3081. It would be good to use a similar field name "_oi" or "_ostid" for other ost_id members in other structures as well.