[LU-2882] lustre build broken with no zfs libraries installed

• Type: Bug
• Resolution: Fixed
• Priority: Blocker
• Fix Version/s: Lustre 2.4.0
• Affects Version/s: Lustre 2.4.0
• Labels: MB
• Environment: clean rhel6 build env.
• Severity: 3
• Assignee: Bruno Faccini (Inactive)
• Reporter: Alexey Lyashkov

Description

after rebaising to last master i see build without zfs libraries broken.

RPM build errors:
File not found: /root/rpmbuild/BUILDROOT/lustre-2.3.61-2.6.32_279.5.2.lustre_g91ba9d3.x86_64/lib/modules/2.6.32-279.5.2.lustre/updates/kernel/fs/lustre/osd_zfs.ko

quick look into spec file say - build_lustre_osd_zfs now is '1' but that is don't checked in build requirements and produced bug in at final phase as osd_zfs isn't build.

i know about workaround with --define "build_lustre_osd_zfs 0" with rpmbuild -tb, but suggest to add some checks for it.
may be via autogenerated package list.

Comments

[Peter Jones]

Landed for 2.4

[Bruno Faccini (Inactive)]

Cool!
Thank's again for you help and tests.
I had to re-run 1st auto-tests due to some weird issues, if successful I will then ask for patch to be landed.

[Alexey Lyashkov]

Verified - with patch i able to build packages correctly.

[Alexey Lyashkov]

Hi Bruno,

sure.

ps. I think patch good after quick look into. but let be run test build.

[Bruno Faccini (Inactive)]

Hello Alexey,
Can you re-try your builds when running with my patch ?
Thank's in advance for your help and answer.

[Bruno Faccini (Inactive)]

Since I am not able to build simply with a simple/only "rpmbuild -tb lustre-source-tarball" command (ldiskfs_* symbols undefined references in osd_*() functions from lustre/utils/mount_utils.c, so again I may need some details on commands/sequence used), I am not sure about the fix, but since my local/Wiki-like builds tests with it have been successful, let's have a try with patch at http://review.whamcloud.com/5661 on Hudson/Jenkins side.

[Bruno Faccini (Inactive)]

But back on my previous comment about the different ways to build Lustre, is this "rpmbuild -tb lustre-source-tarball" a usual one ??

Also, are there others known ?

[Bruno Faccini (Inactive)]

Ho thank's Oleg I see, he uses "rpmbuild -tb" on a source tar-ball. Yes, this may be the trick, because changes from LU-2391 have only been exposed vs local builds as described on the WiKi and Hudson/Jenkins (aka "lbuild") builds.

And, particularly, the "lbuild" ones are using "rpmbuild -tb" command but with a lot of spec-file variables pre-setting (like %configure !!...) mainly coming from "autoconf/configure", and I am afraid that a simple "rpmbuild -tb" will only get embryonic configure infos that will not allow to decide if ZFS is installed or not.

I will try to revert the default value from 1 to 0 for build_lustre_osd_zfs/build_lustre_osd_ldiskfs, and see if it fixes.

[Oleg Drokin]

Bruno, it seems what shadow is doing is just
rpm -tb lustre.spc on a system with no zfs/spl stuff installed.
Please try that and see if it fails for you, and if so, please see if you can fix it.

[Bruno Faccini (Inactive)]

Hello Alexey,
Can you better detail me with the commands/setup you use for your build ?
It will help me to find any holes in the add-ons for these OSD RPMs in the spec file.