Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-2947

OBD_FAIL_PTLRPC_HPREQ_* implementation broken after NRS landing

Details

    • Bug
    • Resolution: Not a Bug
    • Major
    • None
    • Lustre 2.4.0
    • None
    • 3
    • 7072

    Description

      NRS code landing changed ptlrpc_request_get logic to require a request to be removed from queue explicitly, but did not update all callers.
      OBD_FAIL_PTLRPC_HPREQ_* handling in ptlrpc_server_handle_request is not updated and so these requests are not lost as they were supposed to according to the original logic.

      This ticket is opened in case the API change reversal discussed in LU-398 (to not actually require explicit queue removal for fetched requests) falls through and does not make it into 2.4 and we need to close the problem by other means.

      Attachments

        Issue Links

          is related to

          New Feature - A new feature of the product, which has yet to be developed. LU-398 NRS (Network Request Scheduler )

          • Major - Major loss of function.
          • Resolved

          Activity

            [LU-2947] OBD_FAIL_PTLRPC_HPREQ_* implementation broken after NRS landing
            green Oleg Drokin added a comment -

            this is actually not a bug, I misread the code.

            green Oleg Drokin added a comment - this is actually not a bug, I misread the code.
            green Oleg Drokin added a comment -

            tentative patch in http://review.whamcloud.com/5678

            green Oleg Drokin added a comment - tentative patch in http://review.whamcloud.com/5678

            People

              wc-triage WC Triage
              green Oleg Drokin
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: