Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-3231

fld_cache_lookup() copies fld_cache_entry onto lu_seq_range

Details

    • Bug
    • Resolution: Fixed
    • Blocker
    • Lustre 2.4.0
    • Lustre 2.4.0
    • 3
    • 7896

    Description

      fld_cache_lookup() keeps a prev pointer to a struct fld_cache_entry. But when it uses this pointer to return the prev range, it copies the entry onto the range argument and not the entry's fce_range member.

      int fld_cache_lookup(struct fld_cache *cache,
                           const seqno_t seq, struct lu_seq_range *range)
      {
              struct fld_cache_entry *flde;
              struct fld_cache_entry *prev = NULL;
              cfs_list_t *head;
              ENTRY;
      
              ...
              cfs_list_for_each_entry(flde, head, fce_list) {
                      if (flde->fce_range.lsr_start > seq) {
                              if (prev != NULL)
                                      memcpy(range, prev, sizeof(*range));
                              break;
                      }
              ...
      }
      

      Attachments

        Issue Links

          Activity

            [LU-3231] fld_cache_lookup() copies fld_cache_entry onto lu_seq_range
            jlevi Jodi Levi (Inactive) made changes -
            Labels Original: LB fld New: LB fid
            pjones Peter Jones made changes -
            Fix Version/s New: Lustre 2.4.0 [ 10154 ]
            Resolution New: Fixed [ 1 ]
            Status Original: Open [ 1 ] New: Resolved [ 5 ]
            pjones Peter Jones made changes -
            Assignee Original: WC Triage [ wc-triage ] New: John Hammond [ jhammond ]
            jlevi Jodi Levi (Inactive) made changes -
            Labels Original: fld New: LB fld
            jhammond John Hammond made changes -
            Priority Original: Minor [ 4 ] New: Blocker [ 1 ]
            jhammond John Hammond made changes -
            Link New: This issue is related to LU-3233 [ LU-3233 ]
            jhammond John Hammond created issue -

            People

              jhammond John Hammond
              jhammond John Hammond
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: