Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-3346

The assignment of obt_sb was removed

Details

    • Bug
    • Resolution: Fixed
    • Major
    • Lustre 2.5.0
    • Lustre 2.4.0
    • 3
    • 8274

    Description

      Hi,

      Coverity has found a strange piece of code in check_and_start_recovery_timer() function:

      if (!(lsi->lsi_flags | LDD_F_IR_CAPABLE))
      service_time += 2 * (CONNECTION_SWITCH_MAX +
      CONNECTION_SWITCH_INC);

      According to the tool, 'lsi->lsi_flags | LDD_F_IR_CAPABLE' is useless because it is always true. So it seems the developer meant to use '&' instead of '|'.

      But if we change the code accordingly, then we hit a number of issues because of unprotected access to recovery timer, as seen in https://maloo.whamcloud.com/test_sessions/96125f26-bc36-11e2-b013-52540035b04c

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. LU-2753 Tracking bug for static code analysis fixes.

          • Trivial - Cosmetic problem like misspelt words or misaligned text.
          • Resolved

          Task - A task that needs to be done. LU-1330 split/cleanup for obdclass/fid/fld modules

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Activity

            [LU-3346] The assignment of obt_sb was removed
            adilger Andreas Dilger made changes -
            Link New: This issue is related to LU-1330 [ LU-1330 ]
            adilger Andreas Dilger made changes -
            Link New: This issue is related to LU-2753 [ LU-2753 ]
            adilger Andreas Dilger made changes -
            Parent Original: LU-2753 [ 17451 ]
            Severity New: 3 [ 10022 ]
            Issue Type Original: Technical task [ 7 ] New: Bug [ 1 ]
            adilger Andreas Dilger made changes -
            Parent New: LU-2753 [ 17451 ]
            Severity Original: 3 [ 10022 ]
            Issue Type Original: Bug [ 1 ] New: Technical task [ 7 ]
            dmiter Dmitry Eremin (Inactive) made changes -
            Fix Version/s New: Lustre 2.5.0 [ 10295 ]
            Resolution New: Fixed [ 1 ]
            Status Original: In Progress [ 3 ] New: Resolved [ 5 ]
            dmiter Dmitry Eremin (Inactive) made changes -
            Status Original: Open [ 1 ] New: In Progress [ 3 ]
            dmiter Dmitry Eremin (Inactive) made changes -
            Assignee Original: Jinshan Xiong [ jay ] New: Dmitry Eremin [ dmiter ]
            dmiter Dmitry Eremin (Inactive) made changes -
            Summary Original: Unprotected access to recovery timer New: The assignment of obt_sb was removed
            jlevi Jodi Levi (Inactive) made changes -
            Assignee Original: Dmitry Eremin [ dmiter ] New: Jinshan Xiong [ jay ]
            pjones Peter Jones made changes -
            Assignee Original: WC Triage [ wc-triage ] New: Dmitry Eremin [ dmiter ]
            sebastien.buisson Sebastien Buisson (Inactive) created issue -

            People

              dmiter Dmitry Eremin (Inactive)
              sebastien.buisson Sebastien Buisson (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: