Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-2753 Tracking bug for static code analysis fixes.
  3. LU-3427

Fix 'error handling' issues

Details

    • 8500

    Description

      Following LU-2444, Coverity found a few more error handling issues in the Lustre code.

      I will propose a patch to address the issues.

      Attachments

        Activity

          [LU-3427] Fix 'error handling' issues
          adilger Andreas Dilger made changes -
          Parent New: LU-2753 [ 17451 ]
          Issue Type Original: Task [ 3 ] New: Technical task [ 7 ]
          pjones Peter Jones made changes -
          Fix Version/s New: Lustre 2.4.1 [ 10294 ]
          bobbielind Bobbie Lind (Inactive) made changes -
          Fix Version/s New: Lustre 2.5.0 [ 10295 ]
          Resolution New: Fixed [ 1 ]
          Status Original: Reopened [ 4 ] New: Resolved [ 5 ]
          bobbielind Bobbie Lind (Inactive) added a comment -

          Patch has landed to master.

          bobbielind Bobbie Lind (Inactive) added a comment - Patch has landed to master.
          bobbielind Bobbie Lind (Inactive) made changes -
          Resolution Original: Won't Fix [ 2 ]
          Status Original: Resolved [ 5 ] New: Reopened [ 4 ]
          bobbielind Bobbie Lind (Inactive) added a comment -

          Reopened per customer request.

          bobbielind Bobbie Lind (Inactive) added a comment - Reopened per customer request.
          sebastien.buisson Sebastien Buisson (Inactive) added a comment -

          Of course I feel this patch is still needed.
          The point of the patch was to test the return value of cfs_cpt_bind() in cfs_wi_scheduler(). The fact that a local variable was removed from this function does not change this.
          I rewrote the patch replacing the use of this 'name' local variable with sched->ws_name.

          Here is the new patch:
          http://review.whamcloud.com/7103

          Please reopen this ticket.

          Thanks,
          Sebastien.

          sebastien.buisson Sebastien Buisson (Inactive) added a comment - Of course I feel this patch is still needed. The point of the patch was to test the return value of cfs_cpt_bind() in cfs_wi_scheduler(). The fact that a local variable was removed from this function does not change this. I rewrote the patch replacing the use of this 'name' local variable with sched->ws_name. Here is the new patch: http://review.whamcloud.com/7103 Please reopen this ticket. Thanks, Sebastien.
          bobbielind Bobbie Lind (Inactive) made changes -
          Resolution New: Won't Fix [ 2 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]
          bobbielind Bobbie Lind (Inactive) added a comment -

          Variable no longer in code base.

          bobbielind Bobbie Lind (Inactive) added a comment - Variable no longer in code base.
          bobbielind Bobbie Lind (Inactive) added a comment -

          This patch broke the compilation of master and was reverted. After speaking with Oleg, the variable that this patch references no longer exists. If you feel the patch is still needed please submit it again.

          bobbielind Bobbie Lind (Inactive) added a comment - This patch broke the compilation of master and was reverted. After speaking with Oleg, the variable that this patch references no longer exists. If you feel the patch is still needed please submit it again.

          People

            bobbielind Bobbie Lind (Inactive)
            sebastien.buisson Sebastien Buisson (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: