[LU-3476] Eliminate bad macros in lustre spec file

• Type: Technical task
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.5.0
• Affects Version/s: Lustre 2.5.0
• Assignee: Minh Diep
• Reporter: Christopher Morrone (Inactive)

Description

We should really eliminate all of lustre spec file's non-standard use of build_* macros (e.g. build_lustre_osd_ldiskfs) and replace them with rpmbuild's standard -with/-without mechanisms. In fact that goes for any and all binary options we use in the spec file.

If we use the standard mechanisms for this stuff, our rpmbuild command line becomes much cleaner. For instance, this:

rpmbuild --define "build_lustre_osd_ldiskfs 1"

would become

rpmbuild --with ldiskfs

And skipping the build of the server components changes from:

rpmbuild --define "lustre_name lustre-client"

to

rpmbuild --without server

Issue Links

• is duplicated by: LU-3960 Eliminate bad macros in lustre spec file

Comments

[Minh Diep]

patch http://review.whamcloud.com/#/c/6856/

[Peter Jones]

Minh

Could you please look into this one?

Thanks

Peter