Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-3575

'mkfs.lustre --writeconf' not working anymore with Lustre 2.4

Details

    • Bug
    • Resolution: Duplicate
    • Major
    • None
    • Lustre 2.4.0
    • None
    • 3
    • 9043

    Description

      Hi,

      With Lustre 2.4, '--writeconf' flag of mkfs.lustre is ignored. Indeed, after formatting a target with this flag, its label separator is ':', which means VIRGIN, instead of '='.
      To force writeconf, one has to run 'tunefs.lustre --writeconf' on the target prior to starting it for the first time.

      This is seen as a regression compared to Lustre 2.1, with which we can directly pass the writeconf flag at mkfs.lustre time.

      We need this feature (ie forcing writeconf at mkfs time) when we reformat an existing file system registered at an external MGS after modifying its characteristics.

      Could it be possible to revise writeconf flag implementation in Lustre 2.4 so that it can be used directly at mkfs.lustre time?

      TIA,
      Sebastien.

      Attachments

        Issue Links

          Activity

            [LU-3575] 'mkfs.lustre --writeconf' not working anymore with Lustre 2.4
            pjones Peter Jones added a comment -

            Of course - when we start thinking about 2.4.2 this will definitely be under consideration.

            pjones Peter Jones added a comment - Of course - when we start thinking about 2.4.2 this will definitely be under consideration.

            Would it be possible to please have the patch http://review.whamcloud.com/7443 landed to 2.4 too?

            sebastien.buisson Sebastien Buisson (Inactive) added a comment - Would it be possible to please have the patch http://review.whamcloud.com/7443 landed to 2.4 too?
            pjones Peter Jones added a comment -

            Great! So, that patch has landed for 2.5.0 so it sound like this ticket can be closed

            pjones Peter Jones added a comment - Great! So, that patch has landed for 2.5.0 so it sound like this ticket can be closed

            Hi,

            I have tested the patch at http://review.whamcloud.com/7443.

            For us it does the trick. Now, when we need to reformat a new target to replace an existing one, we use '--reformat --replace' instead of '--reformat --writeconf'.

            Thanks!
            Sebastien.

            sebastien.buisson Sebastien Buisson (Inactive) added a comment - - edited Hi, I have tested the patch at http://review.whamcloud.com/7443 . For us it does the trick. Now, when we need to reformat a new target to replace an existing one, we use '--reformat --replace' instead of '--reformat --writeconf'. Thanks! Sebastien.
            adilger Andreas Dilger added a comment - - edited

            The main reason for having a separate flag from --reformat (which is setting VIRGIN exactly because it is a new filesystem) is that there is some chance of the admin making a mistake assigning the OST index, and then we may have two OSTs with the same index. If the --reformat (with VIRGIN) OST connects to the MGS and it has a duplicate index it will get an error back. It takes an extra flag (--replace) to indicate that the admin knows that this just-reformatted OST is replacing the previous OST at the same index.

            adilger Andreas Dilger added a comment - - edited The main reason for having a separate flag from --reformat (which is setting VIRGIN exactly because it is a new filesystem) is that there is some chance of the admin making a mistake assigning the OST index, and then we may have two OSTs with the same index. If the --reformat (with VIRGIN ) OST connects to the MGS and it has a duplicate index it will get an error back. It takes an extra flag ( --replace ) to indicate that the admin knows that this just-reformatted OST is replacing the previous OST at the same index.

            Well, this is getting complicated.

            Why adding another flag to do this? If you do not want writeconf to have precedence over virgin by default, I would suggest to modify the already existing '--reformat' flag so that it unsets the LDD_F_VIRGIN flag. Additionally, it looks like LDD_F_WRITECONF should be set at the same time, otherwise the MGS may refuse registration of the target.

            Moreover, it should be documented somewhere that '--writeconf' flag of mkfs.lustre is ignored starting with 2.4.

            What do you think?

            Sebastien.

            sebastien.buisson Sebastien Buisson (Inactive) added a comment - Well, this is getting complicated. Why adding another flag to do this? If you do not want writeconf to have precedence over virgin by default, I would suggest to modify the already existing '--reformat' flag so that it unsets the LDD_F_VIRGIN flag. Additionally, it looks like LDD_F_WRITECONF should be set at the same time, otherwise the MGS may refuse registration of the target. Moreover, it should be documented somewhere that '--writeconf' flag of mkfs.lustre is ignored starting with 2.4. What do you think? Sebastien.

            yes, this approach looks better.

            bzzz Alex Zhuravlev added a comment - yes, this approach looks better.

            Hmm, I've made a patch http://review.whamcloud.com/7443 which adds the "mkfs.lustre --replace|-R" option that allows you to format a replacement OST in a single step. That is more intuitive IMHO than mkfs.lustre + tunefs.lustre --writeconf.

            adilger Andreas Dilger added a comment - Hmm, I've made a patch http://review.whamcloud.com/7443 which adds the "mkfs.lustre --replace|-R" option that allows you to format a replacement OST in a single step. That is more intuitive IMHO than mkfs.lustre + tunefs.lustre --writeconf.
            spitzcor Cory Spitz added a comment -

            If 'mkfs.lustre --writeconf' is flat broke, why didn't we catch this prior to 2.4.0?

            spitzcor Cory Spitz added a comment - If 'mkfs.lustre --writeconf' is flat broke, why didn't we catch this prior to 2.4.0?

            Hi there,

            I can confirm that this patch (http://review.whamcloud.com/#/c/7232/) solves the problem for me.
            Is it possible to also have it on b2_4?

            TIA,
            Sebastien.

            sebastien.buisson Sebastien Buisson (Inactive) added a comment - Hi there, I can confirm that this patch ( http://review.whamcloud.com/#/c/7232/ ) solves the problem for me. Is it possible to also have it on b2_4? TIA, Sebastien.

            People

              bzzz Alex Zhuravlev
              sebastien.buisson Sebastien Buisson (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              12 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: