[LU-3622] mds_pack_open_flags() checks for O_NOACCESS in it_flags

• Type: Bug
• Resolution: Not a Bug
• Priority: Minor
• Affects Version/s: Lustre 2.5.0
• Severity: 3
• Assignee: WC Triage
• Reporter: John Hammond

Description

Open flags have already had the O_{{RD,WR}ONLY,RDWR} to FMODE_

{READ,WRITE,EXEC}

conversion performed before they are stored in it_flags. So for mds_pack_open_flags() to check for O_NOACCESS == 3 == (FMODE_READ|FMODE_WRITE) in flags is incorrect. Currently this has no ill-effects since the only thing done in this case is to set MDS_OPEN_NORESTORE in cr_flags, and the server side handler ignores this flag.

If the server begins to obey MDS_OPEN_NORESTORE then this would be bad.