[LU-3690] Improve gerrit reporting of patch status

• Type: Task
• Resolution: Not a Bug
• Priority: Minor
• Assignee: Peter Jones
• Reporter: Christopher Morrone

Description

We use gerrit differently than it expects by default. Most importantly, there are two conditions that signal that a patch is done code review and can be sent to the Gate Keeper for landing:

• A +2 CodeReview
  OR
• 2 or more +1 CodeReviews

Unfortunately, there is currently no way to create a reliable positive or negative pattern to match that second condition. That makes it inpossible to create good filters that provide the following useful lists of patches:

• Patches that are fully reviewed and waiting for landing
• Patches that are awaiting further review

On the CDWG mailing list Denis Kondratenko provided a couple of great links that talk about possible solutions for this very problem:

• http://en.wikibooks.org/wiki/Git/Gerrit_Code_Review (A hook could - for instance - allow a project to install an automated gatekeeper to vote +2 'submit approved' when sufficient +1 votes 'looks good to me' have been received)
• http://review.whamcloud.com/Documentation/prolog-cookbook.html#_example_12_1_1_2_code_review (but I don't know if it will get right searches..)