[LU-3694] Posix copytool cleanup

• Type: Technical task
• Resolution: Fixed
• Priority: Blocker
• Fix Version/s: Lustre 2.5.0
• Labels: HSM
• Assignee: Bruno Faccini (Inactive)
• Reporter: Henri Doreau (Inactive)

Description

Several minor issues have been identified during the review of the initial version of the HSM posix copytool, such as calling select() on regular files.

Issue Links

• is related to: LU-3971 CLONE - Posix copytool cleanup
• is related to: LU-3734 Posix Copytool Application Behaviour

Comments

[Henri Doreau (Inactive)]

The syslog issue will be addressed by changes on liblustrapi logging facilities (see LU-3692). I'll propose a patch to get rid of select() but this one has a lower priority.

[jacques-charles lafoucriere]

Patch for new err messages at http://review.whamcloud.com/7568 (faster than expected).
Still need a patch for select() bug, will do a separate one after err msg landing.

[Bruno Faccini (Inactive)]

Hello J-C,

Thanks for the update, but will this also soleve the syslog logging issue ?
And alos are there others issues than the 3 ones already listed ?

[jacques-charles lafoucriere]

Yes we will rewrite all the error messages, I think I can do it in 1 or 2 weeks

[Bruno Faccini (Inactive)]

Hello Henri,
Sorry to ask but do you still think to provide a patch for this ticket ?
Also, did find other issues ?

[Henri Doreau (Inactive)]

We will provide a patch.

IIRC the issues that were identified so far are:

• superfluous select() on regular files
• error messages that should be rewritten for consistency
• logging to syslog isn't possible (related to the former point and to LU-3692)

Current reviews and testing might reveal other ones.

[Peter Jones]

Henri

Will you be supplying a patch to fix these issues or could you elaborate?

Thanks

Peter