Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-3647 HSM _not only_ small fixes and to do list goes here
  3. LU-3694

Posix copytool cleanup

Details

    • Technical task
    • Resolution: Fixed
    • Blocker
    • Lustre 2.5.0
    • None
    • 9536

    Description

      Several minor issues have been identified during the review of the initial version of the HSM posix copytool, such as calling select() on regular files.

      Attachments

        Issue Links

          is related to

          Technical task - A technical task. LU-3971 CLONE - Posix copytool cleanup

          • Major - Major loss of function.
          • Resolved
          is related to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. LU-3734 Posix Copytool Application Behaviour

          • Major - Major loss of function.
          • Closed

          Activity

            [LU-3694] Posix copytool cleanup
            jlevi Jodi Levi (Inactive) added a comment -

            This ticket needs to be a blocker for 2.5 until Change, 7568 lands, then it can be reduced.

            jlevi Jodi Levi (Inactive) added a comment - This ticket needs to be a blocker for 2.5 until Change, 7568 lands, then it can be reduced.
            hdoreau Henri Doreau (Inactive) added a comment -

            Removal of select() is at http://review.whamcloud.com/#/c/7583/

            hdoreau Henri Doreau (Inactive) added a comment - Removal of select() is at http://review.whamcloud.com/#/c/7583/
            jcl jacques-charles lafoucriere added a comment - - edited

            This ticket must stay for 2.5 target, 7568 is a bug

            jcl jacques-charles lafoucriere added a comment - - edited This ticket must stay for 2.5 target, 7568 is a bug
            hdoreau Henri Doreau (Inactive) added a comment -

            The syslog issue will be addressed by changes on liblustrapi logging facilities (see LU-3692). I'll propose a patch to get rid of select() but this one has a lower priority.

            hdoreau Henri Doreau (Inactive) added a comment - The syslog issue will be addressed by changes on liblustrapi logging facilities (see LU-3692 ). I'll propose a patch to get rid of select() but this one has a lower priority.
            jcl jacques-charles lafoucriere added a comment -

            Patch for new err messages at http://review.whamcloud.com/7568 (faster than expected).
            Still need a patch for select() bug, will do a separate one after err msg landing.

            jcl jacques-charles lafoucriere added a comment - Patch for new err messages at http://review.whamcloud.com/7568 (faster than expected). Still need a patch for select() bug, will do a separate one after err msg landing.
            bfaccini Bruno Faccini (Inactive) added a comment -

            Hello J-C,

            Thanks for the update, but will this also soleve the syslog logging issue ?
            And alos are there others issues than the 3 ones already listed ?

            bfaccini Bruno Faccini (Inactive) added a comment - Hello J-C, Thanks for the update, but will this also soleve the syslog logging issue ? And alos are there others issues than the 3 ones already listed ?
            jcl jacques-charles lafoucriere added a comment -

            Yes we will rewrite all the error messages, I think I can do it in 1 or 2 weeks

            jcl jacques-charles lafoucriere added a comment - Yes we will rewrite all the error messages, I think I can do it in 1 or 2 weeks
            bfaccini Bruno Faccini (Inactive) added a comment -

            Hello Henri,
            Sorry to ask but do you still think to provide a patch for this ticket ?
            Also, did find other issues ?

            bfaccini Bruno Faccini (Inactive) added a comment - Hello Henri, Sorry to ask but do you still think to provide a patch for this ticket ? Also, did find other issues ?
            hdoreau Henri Doreau (Inactive) added a comment -

            We will provide a patch.

            IIRC the issues that were identified so far are:

            • superfluous select() on regular files
            • error messages that should be rewritten for consistency
            • logging to syslog isn't possible (related to the former point and to LU-3692)

            Current reviews and testing might reveal other ones.

            hdoreau Henri Doreau (Inactive) added a comment - We will provide a patch. IIRC the issues that were identified so far are: superfluous select() on regular files error messages that should be rewritten for consistency logging to syslog isn't possible (related to the former point and to LU-3692 ) Current reviews and testing might reveal other ones.
            pjones Peter Jones added a comment -

            Henri

            Will you be supplying a patch to fix these issues or could you elaborate?

            Thanks

            Peter

            pjones Peter Jones added a comment - Henri Will you be supplying a patch to fix these issues or could you elaborate? Thanks Peter

            People

              bfaccini Bruno Faccini (Inactive)
              hdoreau Henri Doreau (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: