[LU-3856] No volume label updates after registered target

• Type: Bug
• Resolution: Fixed
• Priority: Critical
• Fix Version/s: Lustre 2.5.0
• Affects Version/s: Lustre 2.4.0
• Severity: 3
• Assignee: Alex Zhuravlev
• Reporter: Alexander Boyko

Description

reproducer

mkfs.lustre --mgs --mdt  --fsname=lustre --device-size=100000 --reformat /dev/sdb
mount -t lustre -o nosvc,abort_recov  -n /dev/sdb /mnt/mgt
e2label /dev/sdb
mount -t lustre -o nomgs,abort_recov  -n /dev/sdb /mnt/mdt
e2label /dev/sdb

For 2.3 Lustre the result of e2label is

lustre:MDT0000
lustre-MDT0000

For 2.4 Lustre

lustre:MDT0000
lustre:MDT0000

Later this cause error ... index is already in use.

I think that this part of mount_lustre.c is invalid.

    } else if (!mop.mo_nomtab) {
                rc = update_mtab_entry(mop.mo_usource, mop.mo_target, "lustre",
                                       mop.mo_orig_options, 0,0,0);

                /* change label from <fsname>:<index> to <fsname>-<index>
                 * to indicate the device has been registered. */
                if (mop.mo_ldd.ldd_flags & LDD_F_VIRGIN)
                        (void) osd_label_lustre(&mop);
        }

The volume label update should be done in any case with update mtab or not.