Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-3647 HSM _not only_ small fixes and to do list goes here
  3. LU-3902

lhsmtool_posix uses llapi_printf for error reporting

Details

    • Technical task
    • Resolution: Duplicate
    • Blocker
    • None
    • Lustre 2.5.0
    • 10256

    Description

      This is bad for several reasons. Errors should always go to stderr. stdout is buffered. This is why most of the copytool test logs contain only the line "exiting: Interrupt".

      Attachments

        Activity

          [LU-3902] lhsmtool_posix uses llapi_printf for error reporting
          jlevi Jodi Levi (Inactive) added a comment -

          Removed fixversion as this is a duplicate.

          jlevi Jodi Levi (Inactive) added a comment - Removed fixversion as this is a duplicate.
          jhammond John Hammond added a comment -

          Duplicate of LU-3694.

          jhammond John Hammond added a comment - Duplicate of LU-3694 .
          jay Jinshan Xiong (Inactive) added a comment -

          Hi Bruno,

          can you please take this over?

          Jinshan

          jay Jinshan Xiong (Inactive) added a comment - Hi Bruno, can you please take this over? Jinshan
          jhammond John Hammond added a comment -

          No. Output goes to stdout. Errors go to stderr.

          Anyway JC is fixing this in http://review.whamcloud.com/#/c/7568 for LU-3694 so I suggest we bump that up to blocker.

          jhammond John Hammond added a comment - No. Output goes to stdout. Errors go to stderr. Anyway JC is fixing this in http://review.whamcloud.com/#/c/7568 for LU-3694 so I suggest we bump that up to blocker.
          jay Jinshan Xiong (Inactive) added a comment -

          Let's set stdout to unbuffered in posix tool thread by calling

          setvbuf(stdout, NULL, _IOLBF, 0);

          It's not totally bad to use llapi_printf() in CT because libraries may report error via it so it's actually good to have a common error report interface.

          jay Jinshan Xiong (Inactive) added a comment - Let's set stdout to unbuffered in posix tool thread by calling setvbuf(stdout, NULL, _IOLBF, 0); It's not totally bad to use llapi_printf() in CT because libraries may report error via it so it's actually good to have a common error report interface.

          People

            wc-triage WC Triage
            jhammond John Hammond
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: