[LU-3903] build fails with latest zfs source

• Type: Bug
• Resolution: Fixed
• Priority: Blocker
• Fix Version/s: Lustre 2.5.0, Lustre 2.4.2
• Affects Version/s: Lustre 2.6.0
• Labels: zfs
• Severity: 3
• Assignee: Nathaniel Clark
• Reporter: Bob Glossman (Inactive)

Description

I can no longer build lustre against the latest upstream zfs source pulled from the master branch of github.com/behlendorf/zfs.git. A recent commit has eliminated the internal API dsl_prop_set() used in osd-zfs code.

This is not currently a problem in our build and test framework where builds are done against an earlier, fixed, and frozen version of zfs source. It will become a problem the next time we sync up to the latest upstream zfs version.

Issue Links

• is related to: LU-3678 Update zfs build version to 0.6.2

Comments

[Peter Jones]

Landed for 2.5.0

[Nathaniel Clark]

http://review.whamcloud.com/7685

[Nathaniel Clark]

The change in ZFS is relatively minor, but needs a configure change in lustre to detect the difference.

ZFS change is 13fe019870c8779bf2f5b3ff731b512cf89133ef

Change needed in lustre is in lustre/osd-zfs/udmu.c in udmu_userprop_set_str() need to use dsl_prop_set_string() if it exists instead of dsl_prop_set().

Otherwise, code compiles without issue.

[Nathaniel Clark]

From what Bob told me via IM, the offending change is after the 0.6.2 tag, so this doesn't directly affect LU-3678.

[Jodi Levi (Inactive)]

Nathaniel,
Can you please look into this one?

[Bob Glossman (Inactive)]

I note that the offending commit that changed the zfs API in an incompatible way went in after the 0.6.2 tag. We can build OK against the upstream zfs-0.6.2 version.