[LU-4088] echo_copyout_lsm wrong copy size

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.6.0
• Severity: 3
• Assignee: WC Triage
• Reporter: Oleg Drokin

Description

Found by Thomas Meyer <[e-mail]> and submitted to mainline kernel:

Author: Thomas Meyer <[e-mail]>
Date:   Thu Sep 19 23:45:46 2013 +0200

    staging: lustre: Cocci spatch "noderef"
    
    sizeof when applied to a pointer typed expression gives the size of the
    pointer.
    Found by coccinelle spatch "misc/noderef.cocci"
    
    Signed-off-by: Thomas Meyer <[e-mail]>
    Signed-off-by: Greg Kroah-Hartman <[e-mail]>

diff --git a/drivers/staging/lustre/lustre/obdecho/echo_client.c b/drivers/stagi
index 2644edf..c8b4344 100644
--- a/drivers/staging/lustre/lustre/obdecho/echo_client.c
+++ b/drivers/staging/lustre/lustre/obdecho/echo_client.c
@@ -1387,7 +1387,7 @@ echo_copyout_lsm (struct lov_stripe_md *lsm, void *_ulsm, 
        if (nob > ulsm_nob)
                return (-EINVAL);
 
-       if (copy_to_user (ulsm, lsm, sizeof(ulsm)))
+       if (copy_to_user (ulsm, lsm, sizeof(*ulsm)))
                return (-EFAULT);