[LU-4530] Mainline kernel client (3.12-3.14): lfs quota -u ... -> Permission denied

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Labels: patch
• Severity: 3
• Assignee: Oleg Drokin
• Reporter: Cédric Dufour

Description

Hello,

'lfs quota -u $(whoami)...' reports "Permission denied' for regular users. It works if the same user queries the quota for another user:

$ whoami
cdufour

$ lfs quota -u $(whoami) /idiap/temp/$(whoami)
Permission denied.

$ lfs quota -u formaz /idiap/temp/formaz
Disk quotas for user formaz (uid 1005):
Filesystem kbytes quota limit grace files quota limit grace
/idiap/temp/formaz
113371820 1072693248 1073741824 - 452499 9999900 10000000 -

(patch follows as soon as I have the LU-<ID> for this bug)

Best,

Cédric

Issue Links

• is related to: LU-4011 problems with upstream lustre client code
• is related to: LU-4416 support for 3.12 linux kernel
• is related to: LU-6215 Sync Lustre external tree with lustre linux kernel client

Comments

[Yang Sheng]

Close as James's comment.

[James A Simmons]

The fix

commit 8b9e418c013e8b671fc10108ab14243f0657bffd
Author: Cédric Dufour - Idiap Research Institute <[e-mail]>
Date: Fri Jan 24 20:57:05 2014 +0100

staging: lustre: fix quotactl permission denied (LU-4530)

The changes introduced in commit 4b1a25f06b30b203 ("fix build when
CONFIG_UIDGID_STRICT_TYPE_CHECKS is on") got the UID check the wrong way
around, leading to "Permission denied" when a regular user attempts to
retrieve his quota (lfs quota -u ...) but allowing him to retrieve other
users quota.

Full details at: https://jira.hpdd.intel.com/browse/LU-4530

Cc: Peng Tao <[e-mail]>
Cc: <[e-mail]> # 3.12.x
Cc: <[e-mail]> # 3.13.x
Signed-off-by: Cédric Dufour <[e-mail]>
Signed-off-by: Greg Kroah-Hartman <[e-mail]>

was landed upstream. This ticket can be closed.

[James A Simmons]

Peter you can close this ticket as well since the patch has landed upstream.

[James A Simmons]

This patch landed upstream. We can now close this ticket.

[Oleg Drokin]

LU-4416 is not related to in-kernel client, instead it's for our efforts to make our lustre version to compile against mainline kernel.
There's certainly some overlap, but please file in-kernel client bugreports separately ad marked as such

[Roland Fehrenbacher]

Thanks for your detailed answer to my questions. I am glad to see you are putting further
effort into the vanilla kernel client. Looking forward to the days, when the server code will
compile against recent vanilla kernels as well