[LU-4833] osd-zfs: object/buffer leak in __osd_object_create()

• Type: Bug
• Resolution: Fixed
• Priority: Critical
• Fix Version/s: Lustre 2.6.0
• Labels: zfs
• Severity: 3
• Assignee: Isaac Huang (Inactive)
• Reporter: Isaac Huang (Inactive)

Description

If __osd_object_create() fails, references to the new DMU object and its dmu_buf_t are both lost. For example, in osd_mksym() and osd_mknod(), when __osd_object_create() returns error, the callers simply return ERR_PTR(rc); without doing anything else, then both the new DMU object and its dmu_buf_t are leaked.

So __osd_object_create() should clean it up before returning error. There's a similar problem in __osd_zap_create().

Comments

[Jodi Levi (Inactive)]

Patch landed to Master.

[Isaac Huang (Inactive)]

Fix pushed at: http://review.whamcloud.com/#/c/10362/

[Isaac Huang (Inactive)]

I think it should be minor, rather than critical. I'll work on a fix the coming week.

[Andreas Dilger]

Isaac, are you working on a patch for this bug? It is marked as a critical bug for the 2.6.0 release.