Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-4833

osd-zfs: object/buffer leak in __osd_object_create()

Details

    • Bug
    • Resolution: Fixed
    • Critical
    • Lustre 2.6.0
    • None
    • 3
    • 13320

    Description

      If __osd_object_create() fails, references to the new DMU object and its dmu_buf_t are both lost. For example, in osd_mksym() and osd_mknod(), when __osd_object_create() returns error, the callers simply return ERR_PTR(rc); without doing anything else, then both the new DMU object and its dmu_buf_t are leaked.

      So __osd_object_create() should clean it up before returning error. There's a similar problem in __osd_zap_create().

      Attachments

        Activity

          [LU-4833] osd-zfs: object/buffer leak in __osd_object_create()
          pjones Peter Jones made changes -
          Link New: This issue is related to LDEV-45 [ LDEV-45 ]
          jlevi Jodi Levi (Inactive) made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]
          jlevi Jodi Levi (Inactive) added a comment -

          Patch landed to Master.

          jlevi Jodi Levi (Inactive) added a comment - Patch landed to Master.
          isaac Isaac Huang (Inactive) added a comment -

          Fix pushed at: http://review.whamcloud.com/#/c/10362/

          isaac Isaac Huang (Inactive) added a comment - Fix pushed at: http://review.whamcloud.com/#/c/10362/
          isaac Isaac Huang (Inactive) added a comment -

          I think it should be minor, rather than critical. I'll work on a fix the coming week.

          isaac Isaac Huang (Inactive) added a comment - I think it should be minor, rather than critical. I'll work on a fix the coming week.
          adilger Andreas Dilger added a comment -

          Isaac, are you working on a patch for this bug? It is marked as a critical bug for the 2.6.0 release.

          adilger Andreas Dilger added a comment - Isaac, are you working on a patch for this bug? It is marked as a critical bug for the 2.6.0 release.
          jlevi Jodi Levi (Inactive) made changes -
          Priority Original: Minor [ 4 ] New: Critical [ 2 ]
          jlevi Jodi Levi (Inactive) made changes -
          Fix Version/s New: Lustre 2.6.0 [ 10595 ]
          isaac Isaac Huang (Inactive) created issue -

          People

            isaac Isaac Huang (Inactive)
            isaac Isaac Huang (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: