[LU-4901] Remove triple buffer update from llog_osd_write_blob()

• Type: Improvement
• Resolution: Duplicate
• Priority: Blocker
• Affects Version/s: Lustre 2.6.0
• Assignee: Mikhail Pershin
• Reporter: Mikhail Pershin

Description

The llog_osd_write_blob() have two ways to update llog record, the first one is just normal record write with header, buffer and tail at once, the second is actually three separate writes for header, buffer and tail. The latest produces number of troubles because one of three writes may fail causing partially written buffer and corrupted llog. There is special undo procedure to clean things up after that. All of these demands twice more credits for normal operations and for undo case which is critical in case of wide striping.

Meanwhile this particular triple write case is used only by MGS and can be avoided by preparing correct llog record before calling llog_write(). That would require additional memory allocations to prepare write buffer.

Issue Links

• is related to: LU-4528 osd_trans_exec_op()) ASSERTION( oti->oti_declare_ops_rb[rb] > 0 ) failed: rb = 0
• is related to: LU-4183 MDS crash when running fsx with NFS export

Comments

[Jodi Levi (Inactive)]

Reopening to remove fix version as this is a duplicate

[Jodi Levi (Inactive)]

Duplicate of LU-4528.

[Andreas Dilger]

While you are in here, can you please change osd_trans_exec_op():

                if (unlikely(rb >= OSD_OT_MAX)) {
                        if (unlikely(ldiskfs_track_declares_assert))
                                LASSERTF(rb < OSD_OT_MAX, "rb = %u\n", rb);
                        else {
                                CWARN("%s: Invalid rollback index %d\n",
                                      osd_name(oti->oti_dev), rb);
                                libcfs_debug_dumpstack(NULL);
                                return;
                        }
                }

so that it has proper braces around the "if" part of these checks, and only prints this CWARN() and dumpstack once per mount. Otherwise it spews to the stack.