Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-4901

Remove triple buffer update from llog_osd_write_blob()

Details

    • Improvement
    • Resolution: Duplicate
    • Blocker
    • None
    • Lustre 2.6.0
    • None
    • 13537

    Description

      The llog_osd_write_blob() have two ways to update llog record, the first one is just normal record write with header, buffer and tail at once, the second is actually three separate writes for header, buffer and tail. The latest produces number of troubles because one of three writes may fail causing partially written buffer and corrupted llog. There is special undo procedure to clean things up after that. All of these demands twice more credits for normal operations and for undo case which is critical in case of wide striping.

      Meanwhile this particular triple write case is used only by MGS and can be avoided by preparing correct llog record before calling llog_write(). That would require additional memory allocations to prepare write buffer.

      Attachments

        Issue Links

          Activity

            [LU-4901] Remove triple buffer update from llog_osd_write_blob()
            jlevi Jodi Levi (Inactive) made changes -
            Resolution New: Duplicate [ 3 ]
            Status Original: Reopened [ 4 ] New: Closed [ 6 ]
            jlevi Jodi Levi (Inactive) made changes -
            Fix Version/s Original: Lustre 2.6.0 [ 10595 ]
            jlevi Jodi Levi (Inactive) made changes -
            Resolution Original: Duplicate [ 3 ]
            Status Original: Closed [ 6 ] New: Reopened [ 4 ]
            jlevi Jodi Levi (Inactive) made changes -
            Resolution New: Duplicate [ 3 ]
            Status Original: Open [ 1 ] New: Closed [ 6 ]
            jlevi Jodi Levi (Inactive) made changes -
            Priority Original: Critical [ 2 ] New: Blocker [ 1 ]
            adilger Andreas Dilger made changes -
            Link New: This issue is related to LU-4183 [ LU-4183 ]
            adilger Andreas Dilger made changes -
            Fix Version/s New: Lustre 2.6.0 [ 10595 ]
            adilger Andreas Dilger made changes -
            Affects Version/s New: Lustre 2.6.0 [ 10595 ]
            adilger Andreas Dilger made changes -
            Priority Original: Minor [ 4 ] New: Critical [ 2 ]
            tappro Mikhail Pershin made changes -
            Link New: This issue is related to LU-4528 [ LU-4528 ]
            tappro Mikhail Pershin created issue -

            People

              tappro Mikhail Pershin
              tappro Mikhail Pershin
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: