Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-4922

Fix cfs_str2mask to better deal with garbage input

Details

    • Improvement
    • Resolution: Fixed
    • Minor
    • Lustre 2.17.0
    • Lustre 2.1.6, Lustre 2.6.0, Lustre 2.5.1, Lustre 2.4.3, Lustre 2.15.3
    • 3
    • 13606

    Description

      Currently if you feed garbage input into cfs_str2mask, for example empty string, it would reset the value to min_mask where as I imagine it should just do nothing.
      Prime example of this is changelog_mask, I guess.

      So this needs to be fixed.
      Also once done, sanity test 133g should be updated to no longer exclude that file.

      Attachments

        Issue Links

          Activity

            [LU-4922] Fix cfs_str2mask to better deal with garbage input
            pjones Peter Jones added a comment -

            Merged for 2.17

            pjones Peter Jones added a comment - Merged for 2.17

            "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/56619/
            Subject: LU-4922 cfs_str2mask: Handle passing in a blank string better
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 93ba9bfa262bfcbfb500e9e54ef9b59e8f1e9cba

            gerrit Gerrit Updater added a comment - "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/56619/ Subject: LU-4922 cfs_str2mask: Handle passing in a blank string better Project: fs/lustre-release Branch: master Current Patch Set: Commit: 93ba9bfa262bfcbfb500e9e54ef9b59e8f1e9cba

            "Ronnie Sahlberg <rsahlberg@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/56619
            Subject: LU-4922 cfs_str2mask: Handle passing in a blank string better
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 75fe619505e009694afa251e1aedee5315a1c8ae

            gerrit Gerrit Updater added a comment - "Ronnie Sahlberg <rsahlberg@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/56619 Subject: LU-4922 cfs_str2mask: Handle passing in a blank string better Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 75fe619505e009694afa251e1aedee5315a1c8ae
            mdiep Minh Diep added a comment -

            [ 9461.895489] Lustre: 545572:0:(libcfs_string.c:112:cfs_str2mask()) unknown mask ''.

            mdiep Minh Diep added a comment - [ 9461.895489] Lustre: 545572:0:(libcfs_string.c:112:cfs_str2mask()) unknown mask ''.

            People

              rsahlberg@whamcloud.com Ronnie Sahlberg
              green Oleg Drokin
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: