[LU-4962] oops in ll_intent_file_open() during migration

• Type: Bug
• Resolution: Fixed
• Priority: Major
• Fix Version/s: Lustre 2.6.0
• Affects Version/s: Lustre 2.6.0
• Labels: dne2 llite lmv migration
• Severity: 3
• Assignee: John Hammond
• Reporter: John Hammond

Description

If lmv_intent_open() returns before setting *reqp then __ptlrpc_req_finished() will oops when call on the way out of ll_intent_file_open().

[86063.211312] LustreError: 26435:0:(lmv_obd.c:114:lmv_name_to_stripe_index()) 17 is being
 migrated: rc = -13
[86063.212615] BUG: unable to handle kernel NULL pointer dereference at 0000000000000376
[86063.213457] IP: [<ffffffffa039e15a>] __ptlrpc_req_finished+0x4a/0x6d0 [ptlrpc]
[86063.213457] PGD 1b1a89067 PUD 204661067 PMD 0 
[86063.213457] Oops: 0000 [#1] SMP 
[86063.213457] last sysfs file: /sys/devices/system/cpu/possible
[86063.213457] CPU 3 
[86063.213457] Modules linked in: lustre(U) ofd(U) osp(U) lod(U) ost(U) mdt(U) mdd(U) mgs(
U) nodemap(U) osd_ldiskfs(U) ldiskfs(U) lquota(U) lfsck(U) obdecho(U) mgc(U) lov(U) osc(U) mdc(U) lmv(U) fid(U) fld(U) ptlrpc(U) obdclass(U) ksocklnd(U) lnet(U) libcfs(U) exportfs jbd sha512_generic sha256_generic autofs4 nfs lockd fscache auth_rpcgss nfs_acl sunrpc ipv6 microcode virtio_balloon virtio_net i2c_piix4 i2c_core ext4 jbd2 mbcache virtio_blk virtio_pci virtio_ring virtio pata_acpi ata_generic ata_piix dm_mirror dm_region_hash dm_log dm_mod [last unloaded: libcfs]
[86063.213457] 
[86063.213457] Pid: 26435, comm: rm Not tainted 2.6.32-431.5.1.el6.lustre.x86_64 #1 Bochs Bochs
[86063.213457] RIP: 0010:[<ffffffffa039e15a>]  [<ffffffffa039e15a>] __ptlrpc_req_finished+0x4a/0x6d0 [ptlrpc]
[86063.213457] RSP: 0018:ffff8801f5583b48  EFLAGS: 00010293
[86063.213457] RAX: 5a5a5a5a5a5a5a5a RBX: 0000000000000246 RCX: 0000000000000000
[86063.213457] RDX: 0000000000000001 RSI: 0000000000000000 RDI: 0000000000000246
[86063.213457] RBP: ffff8801f5583b68 R08: 00000000fffffff9 R09: 00000000fffffffc
[86063.213457] R10: 0000000000000001 R11: 0000000000000000 R12: 0000000000000000
[86063.213457] R13: ffff8801b36cd068 R14: ffff880201f0e508 R15: 0000000000000000
[86063.213457] FS:  00007f1a9d274700(0000) GS:ffff88002fe00000(0000) knlGS:0000000000000000
[86063.213457] CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b
[86063.213457] CR2: 0000000000000376 CR3: 00000001f71b2000 CR4: 00000000000006e0
[86063.213457] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[86063.213457] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
[86063.213457] Process rm (pid: 26435, threadinfo ffff8801f5582000, task ffff8801ad118300)
[86063.213457] Stack:
[86063.213457]  ffff880201f0e508 ffff8801f5583c88 00000000fffffff3 ffff8801b36cd068
[86063.213457] <d> ffff8801f5583b78 ffffffffa039f010 ffff8801f5583c08 ffffffffa0aebb1c
[86063.213457] <d> ffff8801f5583bd0 ffffffffa0b18720 0000000000000000 ffff8801fdb86608
[86063.213457] Call Trace:
[86063.213457]  [<ffffffffa039f010>] ptlrpc_req_finished+0x10/0x20 [ptlrpc]
[86063.213457]  [<ffffffffa0aebb1c>] ll_intent_file_open+0x31c/0x7b0 [lustre]
[86063.213457]  [<ffffffffa0b18720>] ? ll_md_blocking_ast+0x0/0x800 [lustre]
[86063.213457]  [<ffffffffa0aeca85>] ll_file_open+0x2c5/0xdb0 [lustre]
[86063.213457]  [<ffffffffa0aceb50>] ? ll_dir_open+0x0/0xf0 [lustre]
[86063.213457]  [<ffffffffa0acec2b>] ll_dir_open+0xdb/0xf0 [lustre]
[86063.213457]  [<ffffffff8119fa5a>] __dentry_open+0x10a/0x360
[86063.213457]  [<ffffffff8124489f>] ? security_inode_permission+0x1f/0x30
[86063.213457]  [<ffffffff8119fdc4>] nameidata_to_filp+0x54/0x70
[86063.213457]  [<ffffffff811b5640>] do_filp_open+0x6d0/0xd30
[86063.213457]  [<ffffffff811c255b>] ? alloc_fd+0x3b/0x160
:

Issue Links

• is related to: LU-2675 clang: code cleanups for sparse static analyzer