Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-4987

Issues introduced by LU-4107

Details

    • Bug
    • Resolution: Fixed
    • Critical
    • Lustre 2.6.0
    • None
    • None
    • 3
    • 13812

    Description

      The patch from LU-4107, change 8033, introduced two bugs:

      1) Duplicate stdio.h include
      2) Changing user-space api based only on one's compiler.

      I don't even understand why folks thought LUSTRE_ANONYMOUS_UNION_NAME was the right thing to do. The commenting is entirely inadequate here ("Fix anonymous union."), so I am not even sure what problem they were trying to fix. As far as I can tell, C++ has anonymous unions as well.

      But regardless of the underlying problem, this does not seem like the solution we want. This makes the user-space API change based only one's choice of compiler. I don't think that is wise.

      Attachments

        Activity

          People

            mdiep Minh Diep
            morrone Christopher Morrone (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: