Details
-
Improvement
-
Resolution: Fixed
-
Minor
-
Lustre 2.6.0
-
None
-
13979
Description
From http://review.whamcloud.com/#/c/9784/3/lustre/osd-ldiskfs/osd_io.c:
Andreas Dilger Apr 24 11:59 PM
(improvement) It would be nice to get a separate patch that changed the niobuf_local "page", "dentry", "len", and "flags" to "lnb_page", "lnb_dentry", etc. so that these things can be found in a reasonable manner. Same for "niobuf_remote" field names.
Seems there is a bit of a start on this in ofd_internal.h to define compat macros, but a single cleanup patch would be better.
At the same time, some consistency in naming the variables used for "niobuf_local" would be good. Sometimes it is "nl", sometimes "lnb", sometimes "local", others "nb", or "res", etc. Probably "lnb" and "rnb" are the most commonly used names, though they are not totally consistent with the struct name (which would imply "nbl" and "nbr").