[LU-5326] conflicting types for ‘umode_t’ on powerpc64

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.6.0
• Affects Version/s: Lustre 2.6.0
• Labels: powerpc64
• Severity: 3
• Assignee: John Hammond
• Reporter: John Hammond

Description

On powerpc64, lustre/lustre_user.h cannot be used unless config.h from the lustre tree has been included.

# uname -r
2.6.32-431.20.3.el6.ppc64
# cat test.c
#include <lustre/lustre_user.h> 

void test(void)
{
}
# gcc -Wall test.c -I$PWD/lustre/include -I$PWD/libcfs/include -c
In file included from /tmp/lustre-release/lustre/include/lustre/lustre_user.h:52,
                 from test.c:3:
/tmp/lustre-release/libcfs/include/libcfs/posix/posix-types.h:50: error: conflicting types for ‘umode_t’
/usr/include/asm/types.h:31: note: previous declaration of ‘umode_t’ was here

This is because on ppc64 umode_t is defined to be unsigned int in asm/types.h.

There is no longer any reason for posix-types.h to define umode_t so let's remove it.

Issue Links

• is related to: LU-4677 e2fsprogs compile error on ppc64: posix-types.h:48: error: conflicting types for 'umode_t'

Comments

[Gerrit Updater]

Christopher J. Morrone ([e-mail]) uploaded a new patch: http://review.whamcloud.com/13446
Subject: LU-5326 libcfs: remove umode_t typedef
Project: fs/lustre-release
Branch: b2_5
Current Patch Set: 1
Commit: 25da8bd81b1ba1710e82b64b4f5a5910dc0a9d18

[Jodi Levi (Inactive)]

Patch landed to b2_6.

[John Hammond]

Please see http://review.whamcloud.com/#/c/11055/.