Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-5326

conflicting types for ‘umode_t’ on powerpc64

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.6.0
    • Lustre 2.6.0
    • 3
    • 14865

    Description

      On powerpc64, lustre/lustre_user.h cannot be used unless config.h from the lustre tree has been included.

      # uname -r
      2.6.32-431.20.3.el6.ppc64
      # cat test.c
      #include <lustre/lustre_user.h> 
      
      void test(void)
      {
      }
      # gcc -Wall test.c -I$PWD/lustre/include -I$PWD/libcfs/include -c
      In file included from /tmp/lustre-release/lustre/include/lustre/lustre_user.h:52,
                       from test.c:3:
      /tmp/lustre-release/libcfs/include/libcfs/posix/posix-types.h:50: error: conflicting types for ‘umode_t’
      /usr/include/asm/types.h:31: note: previous declaration of ‘umode_t’ was here
      

      This is because on ppc64 umode_t is defined to be unsigned int in asm/types.h.

      There is no longer any reason for posix-types.h to define umode_t so let's remove it.

      Attachments

        Issue Links

          Activity

            [LU-5326] conflicting types for ‘umode_t’ on powerpc64
            donut-crowd Donut Crowd (Inactive) made changes -
            Remote Link Original: This issue links to "Page (HPDD Community Wiki)" [ 14741 ]
            donut-crowd Donut Crowd (Inactive) made changes -
            Remote Link Original: This issue links to "Page (HPDD Community Wiki)" [ 14610 ]
            sarah Sarah Liu made changes -
            Remote Link Original: This issue links to "Page (HPDD Community Wiki)" [ 14610 ] New: This issue links to "Page (HPDD Community Wiki)" [ 14610 ]
            sarah Sarah Liu made changes -
            Remote Link New: This issue links to "Page (HPDD Community Wiki)" [ 14741 ]
            sarah Sarah Liu made changes -
            Remote Link New: This issue links to "Page (HPDD Community Wiki)" [ 14610 ]
            pjones Peter Jones made changes -
            Link Original: This issue is related to LDEV-14 [ LDEV-14 ]
            pjones Peter Jones made changes -
            Link New: This issue is related to LDEV-13 [ LDEV-13 ]
            pjones Peter Jones made changes -
            Link New: This issue is related to LDEV-14 [ LDEV-14 ]

            Christopher J. Morrone (chris.morrone.llnl@gmail.com) uploaded a new patch: http://review.whamcloud.com/13446
            Subject: LU-5326 libcfs: remove umode_t typedef
            Project: fs/lustre-release
            Branch: b2_5
            Current Patch Set: 1
            Commit: 25da8bd81b1ba1710e82b64b4f5a5910dc0a9d18

            gerrit Gerrit Updater added a comment - Christopher J. Morrone (chris.morrone.llnl@gmail.com) uploaded a new patch: http://review.whamcloud.com/13446 Subject: LU-5326 libcfs: remove umode_t typedef Project: fs/lustre-release Branch: b2_5 Current Patch Set: 1 Commit: 25da8bd81b1ba1710e82b64b4f5a5910dc0a9d18
            jhammond John Hammond made changes -
            Status Original: Resolved [ 5 ] New: Closed [ 6 ]

            People

              jhammond John Hammond
              jhammond John Hammond
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: