[LU-5329] Remove obsollete nidtbl swabbing code

• Type: Bug
• Resolution: Fixed
• Priority: Critical
• Fix Version/s: Lustre 2.7.0
• Affects Version/s: Lustre 2.7.0
• Labels: MB bb
• Severity: 3
• Assignee: Emoly Liu
• Reporter: Oleg Drokin

Description

lustre/ldlm/ldlm_lib.c has this warning that needs to be fixed:

#if LUSTRE_VERSION_CODE < OBD_OCD_VERSION(2, 6, 51, 0)
        /* 2.2.0 clients always swab nidtbl entries due to a bug, so server
         * will do the swabbing for if the client is using the same endianness.
         *
         * This fixup is version-limited, because we don't want to carry the
         * OBD_CONNECT_MNE_SWAB flag around forever, just so long as we need
         * interop with unpatched 2.2 clients.  For newer clients, servers
         * will never do MNE swabbing, let the client handle that.  LU-1644 */
        export->exp_need_mne_swab = !ptlrpc_req_need_swab(req) &&
                        !(data->ocd_connect_flags & OBD_CONNECT_MNE_SWAB);
#else
#warning "LU-1644: Remove old OBD_CONNECT_MNE_SWAB fixup and exp_need_mne_swab"
#endif

Issue Links

• is related to: LU-1644 lustre b2_2<->master failure on lustre-initialization-1: ASSERTION( entry->mne_length <= ((1UL) << 12) )

Comments

[Jodi Levi (Inactive)]

Patch landed to Master.

[Jodi Levi (Inactive)]

Emoly,
Could you please rebase Change, 8630?

[Andreas Dilger]

I disable this code as part of http://review.whamcloud.com/8630 after 2.6.53, among other cleanups.

It would be great if you could move that patch along to landing. The code could then be deleted in a separate patch as part of this bug.

[Jinshan Xiong (Inactive)]

Andreas can comment this.

[Emoly Liu]

I saw this code from http://review.whamcloud.com/#/c/3897/. So we haven't worked with 2.2 clients any more since 2.6.50, right? Then, do I need to remove other parts of code introduced by the fixes of LU-1644 as well?

[Peter Jones]

Emoly

Could you please look into this one?

Thanks

Peter