[LU-5356] (osc_lock.c:1211:osc_lock_enqueue()) ASSERTION( ols->ols_state == OLS_NEW ) failed: Impossible state: 1

• Type: Bug
• Resolution: Cannot Reproduce
• Priority: Minor
• Affects Version/s: Lustre 2.6.0, Lustre 2.7.0
• Labels: malloc osc
• Severity: 3
• Assignee: WC Triage
• Reporter: John Hammond

Description

In osc_lock_enqueue() if osc_enqueue_base() fails and returns something other than -ECANCELED then I see this while running racer.

[  431.610203] LustreError: 24872:0:(osc_lock.c:1211:osc_lock_enqueue()) ASSERTION( ols->ols_state == OLS_NEW ) failed: Impossible state: 1
[  431.612238] LustreError: 24872:0:(osc_lock.c:1211:osc_lock_enqueue()) LBUG
[  431.613335] Pid: 24872, comm: file_exec.sh
[  431.614021] 
[  431.614022] Call Trace:
[  431.614698]  [<ffffffffa02be8c5>] libcfs_debug_dumpstack+0x55/0x80 [libcfs]
[  431.615824]  [<ffffffffa02beec7>] lbug_with_loc+0x47/0xb0 [libcfs]
[  431.616839]  [<ffffffffa0953320>] ? osc_lock_enqueue+0x0/0x970 [osc]
[  431.617883]  [<ffffffffa0953a72>] osc_lock_enqueue+0x752/0x970 [osc]
[  431.618944]  [<ffffffffa0468a0c>] cl_enqueue_try+0xfc/0x300 [obdclass]
[  431.620017]  [<ffffffffa09ba1ca>] lov_lock_enqueue+0x21a/0xe10 [lov]
[  431.621069]  [<ffffffffa0468a0c>] cl_enqueue_try+0xfc/0x300 [obdclass]
[  431.622156]  [<ffffffffa04693bf>] cl_enqueue_locked+0x6f/0x1f0 [obdclass]
[  431.623281]  [<ffffffffa046974e>] cl_lock_request+0x7e/0x280 [obdclass]
[  431.624373]  [<ffffffffa0e96390>] cl_glimpse_lock+0x180/0x490 [lustre]
[  431.625438]  [<ffffffffa0e96c05>] cl_glimpse_size0+0x1a5/0x1d0 [lustre]
[  431.626524]  [<ffffffffa0e478c6>] ll_getattr+0x2e6/0x800 [lustre]
[  431.627505]  [<ffffffff811b4cd2>] ? user_path_at+0x62/0xa0
[  431.628387]  [<ffffffff8104bc84>] ? __do_page_fault+0x244/0x4b0
[  431.629336]  [<ffffffff811a8711>] vfs_getattr+0x51/0x80
[  431.630196]  [<ffffffff811a87a4>] vfs_fstatat+0x64/0xa0
[  431.631045]  [<ffffffff811a890b>] vfs_stat+0x1b/0x20
[  431.631839]  [<ffffffff811a8934>] sys_newstat+0x24/0x50
[  431.632687]  [<ffffffff81554298>] ? lockdep_sys_exit_thunk+0x35/0x67
[  431.633692]  [<ffffffff810f08f7>] ? audit_syscall_entry+0x1d7/0x200
[  431.634694]  [<ffffffff81554222>] ? trace_hardirqs_on_thunk+0x3a/0x3f
[  431.635722]  [<ffffffff8100b072>] system_call_fastpath+0x16/0x1b
[  431.636689] 

This was found using memory allocation fault injection.