[LU-5382] New static analysis issues in 2.5.58-75-g8b2f9c0

• Type: Bug
• Resolution: Not a Bug
• Priority: Minor
• Labels: kw
• Severity: 3
• Assignee: Dmitry Eremin (Inactive)
• Reporter: Dmitry Eremin (Inactive)

Description

Found 2 new issues in the build 2.5.58-75-g8b2f9c0:

1. Pointer may be dereferenced after it was positively checked for NULL
   • lustre/utils/lustre_lfsck.c: in jt_lfsck_start, Pointer 'optarg' checked for NULL at line 182 may be dereferenced at line 174. Also there are 7 similar errors on line(s) 174, 195, 229, 274.
2. Pointer may be dereferenced after it was positively checked for NULL
   • lustre/utils/lustre_lfsck.c: in jt_lfsck_start, Pointer 'str' checked for NULL at line 182 may be dereferenced at line 237. Also there is one similar error on line 237.

The list of commits from the previous build 2.5.58-35-gb35de52:
8b2f9c0 LU-4578 ptlrpc: Early replies need to honor at_max
9461ed3 LU-4629 ptlrpc: fix NULL pointer dereference of {exp,imp}_obd
97708a7 LU-2675 llapi: find_param cleanup part I
9c09626 LU-4864 tests: cleanup shared files in sanity-hsm
3c1f519 LU-4629 osc: remove constant checks
d775666 LU-4795 obd: Remove server_{get,put}_mount_2() functions
09cc402 LU-4830 tests: only deactivate MDTs of Lustre FSNAME
545c662 LU-4681 utils: Fix error message when using hostname
2af7b2b LU-4934 tests: Account for slow ZFS in sanity-lfsck/9a-b
ee3661b LU-4849 lfs: Avoid double closedir() on err from cb_mv_init()
9cda61a LU-4952 osd: wrong paramters for dmu_tx_hold_write
a862bb2 LU-4951 scripts: report modules changes in dkms RPM config
cf5b4ff LU-3953 build: fix AC_LANG_SOURCE autoconf warnings
53d5b14 LU-4629 lov: fix sscanf format specification
6a9e714 LU-4817 osd: fix some leXX_to_cpu() usage issues
d5ad6ff LU-4676 hsm: Fix return value error of ct_run()
1c3b697 LU-4930 llite: add error handler in inode prepare phase
18667c0 LU-4423 style: Change comment to fit within 80 columns
e9cfbba LU-4423 gss: fix checkpatch warning
2fa49e1 LU-4944 osd: support for zfs-0.6.3
9d69909 LU-4981 tests: remount FS after writes to /proc
26422c3 Revert "LU-2675 obd: decruft md_enqueue() and md_intent_lock()"
a2877f1 LU-2675 obd: decruft md_enqueue() and md_intent_lock()
a44f229 LU-4961 lustre: move ioctls to lustre_ioctl.h
53d78bc LU-4423 ptlrpc: Fix function prototypes
0398926 LU-4423 gss: Fix typo in sec_gss.c
341f9c9 LU-4954 mdd: validate names before create, link, and rename
72f0d50 LU-20 kernel: remove rest of obsolete kernel patches
c177056 LU-4008 mdt: update mdt_getattr comments about EA sizing
381604c LU-2177 ldlm: flock completion fixes.
a7246f9 LU-4858 ofd: statfs small fixes
516621b LU-4717 llite: suppress non active IO error message
62a2a70 LU-3227 tests: fix for acl test
d3ac9fb LU-992 doc: remove old kernels from lustre/ChangeLog
1dbba32 LU-4556 tests: speed up sanity-lfsck and sanity-scrub tests
63e7b15 LU-4895 lfsck: not create object to repair dangling by default
75df074 Revert "LU-4924 llite: Only kill SGID/SUID bits"
70c3795 LU-4924 llite: Only kill SGID/SUID bits
73ef5dc LU-4920 quota: always clear lqe_lockh on lock cancel
a8c9796 LU-4941 lfsck: check LOV EA header properly

Issue Links

• is related to: LU-4629 Issues found by static analysis tools