[LU-5412] mdd_unlink() may pass a NULL object to mdd_write_unlock()

• Type: Bug
• Resolution: Duplicate
• Priority: Minor
• Affects Version/s: Lustre 2.7.0
• Labels: mdd
• Severity: 3
• Assignee: WC Triage
• Reporter: John Hammond

Description

In mdd_unlink() the cobj may be NULL (when called from rm_entry and maybe in other cases). When this is so if mdd_update_time() fails then we call mdd_write_unlock(env, mdd_cobj) with a NULL mdd_cobj.

        la->la_valid = LA_CTIME | LA_MTIME;
        rc = mdd_update_time(env, mdd_pobj, pattr, la, handle);
        if (rc)
                GOTO(cleanup, rc);

        /* Enough for only unlink the entry */
        if (unlikely(mdd_cobj == NULL))
                GOTO(stop, rc);

...
cleanup:
        mdd_write_unlock(env, mdd_cobj);
...

Issue Links

• is duplicated by: LU-5413 mdd_write_lock leaks