Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-5448

Compilation without libreadline broken by LU-5418

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Duplicate
    • Icon: Minor Minor
    • None
    • None
    • None
    • CentOS 6.5, latest master.
    • 3
    • 15166

      The two void declarations added by LU-5418 (http://review.whamcloud.com/11231):
      static void noop_int_fn(int unused) { }
      static void noop_void_fn(void) { }

      Are not used if HAVE_LIBREADLINE is not defined, which results in a compilation error:

      cc1: warnings being treated as errors
      util/parser.c:286: error: 'noop_int_fn' defined but not used
      util/parser.c:287: error: 'noop_void_fn' defined but not used
      make[5]: *** [libcfsutil_a-parser.o] Error 1
      make[5]: *** Waiting for unfinished jobs....
      make[4]: *** [all-recursive] Error 1
      make[3]: *** [all-recursive] Error 1
      make[2]: *** [all-recursive] Error 1
      make[1]: *** [all] Error 2
      error: Bad exit status from /var/tmp/rpm-tmp.nePJql (%build)

      Fix is easy, just wrap those declarations in #ifdef HAVE_LIBREADLINE.

      Patch coming momentarily.

            wc-triage WC Triage
            paf Patrick Farrell (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: