[LU-5466] suspicious else statement in lfsck_del_target()

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.7.0
• Affects Version/s: Lustre 2.7.0
• Labels: lfsck
• Severity: 3
• Assignee: nasf (Inactive)
• Reporter: John Hammond

Description

@@ -2684,10 +2684,6 @@ void lfsck_del_target(const struct lu_en

 unlock:
        if (ltd == NULL) {
*               if (for_ost)
*                       head = &lfsck->li_ost_descs.ltd_orphan;
*               else
*                       head = &lfsck->li_ost_descs.ltd_orphan;

                list_for_each_entry(ltd, head, ltd_orphan_list) {
                        if (ltd->ltd_tgt == tgt) {

Found by the coccinelle script:

// If branch and else branch have same statement.
// Based on a coverity check mentioned in a blog post by Dave Jones.

@@
statement S;
@@

* if (...) S else S

Comments

[nasf (Inactive)]

The patch has been landed to master.

[nasf (Inactive)]

Here is the patch:

http://review.whamcloud.com/11407

[Jodi Levi (Inactive)]

Fan Yong,
Can you please comment on this one?
Thank you!

[Robert Read]

That reminds me of something...