Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-5607

xattr interoperability checks removed.

Details

    • Bug
    • Resolution: Fixed
    • Blocker
    • Lustre 2.7.0
    • None
    • None
    • 3
    • 15686

    Description

      I like to see Intel remove a older and dead code, but it need to do more carefully.

      commit 281671b5ee43c2aea5d5b708aadf10fd1df45b16
      Author: John L. Hammond <john.hammond@intel.com>
      Date:   Thu May 1 16:26:41 2014 -0500
      
          LU-4961 lustre: remove liblustre.h and obd.h from userspace
      
      

      removes a wire checks for a xattr entries.

      -#ifdef LIBLUSTRE_POSIX_ACL
      -
      -       /* Checks for type posix_acl_xattr_entry */
      -       LASSERTF((int)sizeof(posix_acl_xattr_entry) == 8, "found %lld\n",
      -                (long long)(int)sizeof(posix_acl_xattr_entry));
      -       LASSERTF((int)offsetof(posix_acl_xattr_entry, e_tag) == 0, "found %lld\n",
      
      

      so any changes in posix_acl_xattr_entry (used in wire protocol) will don't found during lustre compile.

      Attachments

        Activity

          People

            jhammond John Hammond
            shadow Alexey Lyashkov
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: