[LU-5709] "unified request handlers" commits broke tests

• Type: Bug
• Resolution: Duplicate
• Priority: Major
• Severity: 3
• Assignee: WC Triage
• Reporter: Vitaly Fertman

Description

afaics, there are a number of "unified commit handlers" commits which broke some of IT tests:
LU-3467 mdt: call MDT handlers via unified request handler
LU-3467 ofd: use unified handler for OST requests
LU-2145 server: use unified request handler for MGS
etc

there were different fail_loc which were set&checked per RPC operation code (e.g. OBD_FAIL_LDLM_REPLY, OBD_FAIL_OST_LDLM_REPLY_NET, OBD_FAIL_OST_LDLM_REPLY_NET, etc) which were removed. also looking at the code, it is not clear that all the OBD/CFS_FAIL macros and defines are properly ported to the new code.

as an example - OBD_FAIL_LDLM_REPLY is not used anymore, but the following tests expect it to be used:
recovery-small 53
recovery-small 113
replay-dual 19
replay-single 52
replay-single 73b
therefore tests do nothing now.

This ticket is created to do the proper review of all those commits checking all the FAIL macros/defines are properly ported to the new code.

Issue Links

• duplicates: LU-5604 Lots of FAIL_ID checking are lost