Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-5832

New static analysis issues in lustre_rsync

Details

    • Bug
    • Resolution: Fixed
    • Critical
    • Lustre 2.7.0
    • None
    • 3
    • 16354

    Description

      Found 1 new static analysis issues in 2.6.54-45-g8fab48a:

      1. Buffer Overflow in Bound String Copy
        • lustre/utils/lustre_rsync.c: in lustre_rsync.c, function 'strncpy' may incorrectly check buffer boundaries and may overflow buffer 'info->name' of fixed size (256). Also there is one similar error on line 1135.

      The list of commits since the previous build 2.6.54-29-g7e41c11:

      8fab48a LU-5568 lnet: fix kernel crash when network failed to start
      0a18a6a LU-5756 hsm: add missing return code in llapi_hsm_copytool_register
      bc23995 LU-5743 build: Update to zfs/spl 0.6.3-1.1
      85ba174 LU-5641 tests: ensure user daemon is in group bin
      9849f61 LU-5287 export: hold exp_lock when modify exp_flags
      acdaca8 LU-5674 test: print spl debug info
      b5e911f LU-4942 at: per-export lock callback timeout
      38ec486 LU-5626 ldiskfs: update non-htree dotdot in rename
      8e3d8b7 LU-5675 quota: correctly set II_FL_NONUNQ in dt_index_read()
      2e38757 LU-5519 lfsck: LFSCK code framework adjustment (2)
      ad6dd12 LU-5518 lfsck: recover orphans from backend lost+found
      9ff2d95 LU-5517 lfsck: repair invalid nlink count
      e881286 LU-5727 ldlm: revert changes to ldlm_cancel_aged_policy()
      e0d08c0 LU-5777 quota: reserve enough credits for setattr
      72ae278 LU-5606 tests: add version check codes to conf-sanity test 41c
      0f22e4c LU-1996 lustre: Flexible changelog format.

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. LU-4629 Issues found by static analysis tools

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved

          Activity

            [LU-5832] New static analysis issues in lustre_rsync
            adilger Andreas Dilger made changes -
            Link New: This issue is related to LU-4629 [ LU-4629 ]
            dmiter Dmitry Eremin (Inactive) made changes -
            Resolution New: Fixed [ 1 ]
            Status Original: In Progress [ 3 ] New: Resolved [ 5 ]
            jlevi Jodi Levi (Inactive) made changes -
            Labels Original: kw New: MB kw
            jlevi Jodi Levi (Inactive) made changes -
            Priority Original: Minor [ 4 ] New: Critical [ 2 ]
            jlevi Jodi Levi (Inactive) made changes -
            Fix Version/s New: Lustre 2.7.0 [ 10631 ]
            dmiter Dmitry Eremin (Inactive) made changes -
            Summary Original: New static analysis issues in 2.6.54-45-g8fab48a New: New static analysis issues in lustre_rsync
            dmiter Dmitry Eremin (Inactive) made changes -
            Status Original: Open [ 1 ] New: In Progress [ 3 ]
            dmiter Dmitry Eremin (Inactive) made changes -
            Description Original: Found 1 new static analysis issues in 2.6.54-45-g8fab48a:
            # *Buffer Overflow in Bound String Copy*
            #* {{lustre/utils/lustre_rsync.c}}: in _lustre_rsync.c_, function 'strncpy' may incorrectly check buffer boundaries and may overflow buffer 'info\->name' of fixed size (256). Also there is one similar error on line 1135.

            The list of commits since the previous build 2.6.54-29-g7e41c11:
            |[8fab48a|http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=8fab48a8ef0bad6961c2ca1e2959726252ba43ac]|LU-5568 lnet: fix kernel crash when network failed to start|
            |[0a18a6a|http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=0a18a6a2b2c78a8079131848418a4dc8ebb594d1]|LU-5756 hsm: add missing return code in llapi_hsm_copytool_register|
            |[bc23995|http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=bc23995e8c8b18d2a45b38ff6b12623914bbc66e]|LU-5743 build: Update to zfs/spl 0.6.3-1.1|
            |[85ba174|http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=85ba17462f0605b1ef609ad333cde5a71767b4e2]|LU-5641 tests: ensure user daemon is in group bin|
            |[9849f61|http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=9849f6110680d6846e05e9787f1821b0f86b5461]|LU-5287 export: hold exp_lock when modify exp_flags|
            |[acdaca8|http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=acdaca8426a4ca21dab6f6b39365befb3a8f5ffc]|LU-5674 test: print spl debug info|
            |[b5e911f|http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=b5e911f4a98e60a852fd3c3cd99e5cfeabdc8edc]|LU-4942 at: per-export lock callback timeout|
            |[38ec486|http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=38ec486aeee20345a86dbbd2022d7976337c49b8]|LU-5626 ldiskfs: update non-htree dotdot in rename|
            |[8e3d8b7|http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=8e3d8b71fb4ec61f93d6fdcdaf8afe2f25fdda10]|LU-5675 quota: correctly set II_FL_NONUNQ in dt_index_read()|
            |[2e38757|http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=2e3875738171cfc3525d4f011b16fefffaa74a79]|LU-5519 lfsck: LFSCK code framework adjustment (2)|
            |[ad6dd12|http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=ad6dd123cc475e8babcc1b8698fc4d1963841832]|LU-5518 lfsck: recover orphans from backend lost+found|
            |[9ff2d95|http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=9ff2d957982160103b5d885c9a532ad45bdf8d4d]|LU-5517 lfsck: repair invalid nlink count|
            |[e881286|http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=e8812867e8c6c9eb62174b370cb818985e3d2180]|LU-5727 ldlm: revert changes to ldlm_cancel_aged_policy()|
            |[e0d08c0|http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=e0d08c0642fd65b6ec1f90eaa7da7430e36f5f63]|LU-5777 quota: reserve enough credits for setattr|
            |[72ae278|http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=72ae278ed2af481d35e82586c9aa13286b6e5335]|LU-5606 tests: add version check codes to conf-sanity test 41c|
            |[0f22e4c|http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=0f22e4c098b1f7885ef509bbfc346b3e8905b28d]|LU-1996 lustre: Flexible changelog format.|             		New: Found 1 new static analysis issues in 2.6.54-45-g8fab48a:
            # *Buffer Overflow in Bound String Copy*
            #* {{lustre/utils/lustre_rsync.c}}: in _lustre_rsync.c_, function 'strncpy' may incorrectly check buffer boundaries and may overflow buffer 'info\->name' of fixed size (256). Also there is one similar error on line 1135.

            The list of commits since the previous build 2.6.54-29-g7e41c11:
            |[8fab48a|http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=8fab48a8ef0bad6961c2ca1e2959726252ba43ac]|LU-5568 lnet: fix kernel crash when network failed to start|
            |[0a18a6a|http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=0a18a6a2b2c78a8079131848418a4dc8ebb594d1]|LU-5756 hsm: add missing return code in llapi_hsm_copytool_register|
            |[bc23995|http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=bc23995e8c8b18d2a45b38ff6b12623914bbc66e]|LU-5743 build: Update to zfs/spl 0.6.3-1.1|
            |[85ba174|http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=85ba17462f0605b1ef609ad333cde5a71767b4e2]|LU-5641 tests: ensure user daemon is in group bin|
            |[9849f61|http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=9849f6110680d6846e05e9787f1821b0f86b5461]|LU-5287 export: hold exp_lock when modify exp_flags|
            |[acdaca8|http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=acdaca8426a4ca21dab6f6b39365befb3a8f5ffc]|LU-5674 test: print spl debug info|
            |[b5e911f|http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=b5e911f4a98e60a852fd3c3cd99e5cfeabdc8edc]|LU-4942 at: per-export lock callback timeout|
            |[38ec486|http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=38ec486aeee20345a86dbbd2022d7976337c49b8]|LU-5626 ldiskfs: update non-htree dotdot in rename|
            |[8e3d8b7|http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=8e3d8b71fb4ec61f93d6fdcdaf8afe2f25fdda10]|LU-5675 quota: correctly set II_FL_NONUNQ in dt_index_read()|
            |[2e38757|http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=2e3875738171cfc3525d4f011b16fefffaa74a79]|LU-5519 lfsck: LFSCK code framework adjustment (2)|
            |[ad6dd12|http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=ad6dd123cc475e8babcc1b8698fc4d1963841832]|LU-5518 lfsck: recover orphans from backend lost+found|
            |[9ff2d95|http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=9ff2d957982160103b5d885c9a532ad45bdf8d4d]|LU-5517 lfsck: repair invalid nlink count|
            |[e881286|http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=e8812867e8c6c9eb62174b370cb818985e3d2180]|LU-5727 ldlm: revert changes to ldlm_cancel_aged_policy()|
            |[e0d08c0|http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=e0d08c0642fd65b6ec1f90eaa7da7430e36f5f63]|LU-5777 quota: reserve enough credits for setattr|
            |[72ae278|http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=72ae278ed2af481d35e82586c9aa13286b6e5335]|LU-5606 tests: add version check codes to conf-sanity test 41c|
            |*[0f22e4c|http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=0f22e4c098b1f7885ef509bbfc346b3e8905b28d]*|*LU-1996 lustre: Flexible changelog format.*|
            dmiter Dmitry Eremin (Inactive) made changes -
            Assignee Original: WC Triage [ wc-triage ] New: Dmitry Eremin [ dmiter ]
            dmiter Dmitry Eremin (Inactive) created issue -

            People

              dmiter Dmitry Eremin (Inactive)
              dmiter Dmitry Eremin (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: