[LU-5851] Handle LU-4606 packaging changes for Lustre Server DKMS RPM

• Type: Bug
• Resolution: Fixed
• Priority: Critical
• Fix Version/s: Lustre 2.7.0
• Labels: HB
• Severity: 3
• Assignee: Bruno Faccini (Inactive)
• Reporter: Bruno Faccini (Inactive)

Description

LU-4606 has introduced some packaging changes and particularly one that causes a lib/dso to be shipped inside each of the lustre-osd RPMs.
This breaks current packaging of Lustre Server DKMS RPM which presently builds and provides the osd module but also conflicts with the lustre-osd package!
This leads to the Lustre Server DKMS RPM to be unusable due to the necessary lib/dso for the mount command not to be installed.

Issue Links

• is related to: LU-6013 Separate mount helpers for client and server
• is related to: LU-4606 Lustre hard codes libzfs.so.1 in lustre/utils/mount_utils_zfs.c

Comments

[Jodi Levi (Inactive)]

Patches have landed to Master. Please reopen ticket if more work is still needed.

[Bruno Faccini (Inactive)]

Option #1 (http://review.whamcloud.com/12538) and #2 (http://review.whamcloud.com/12550) patches have been abandoned.

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/12589/
Subject: LU-5851 build: split lustre-osd RPMs
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 2aa189790ca95f0f4f1d32fadea3269080091b02

[Bruno Faccini (Inactive)]

Nathaniel, thanks I think you are right unfortunately and that my testing environment for Option 2 / 12550 was incomplete+wrong and was hiding the libzfs dependency of mount_osd_zfs.so lib. BTW, auto-tests did not trigger it too which may mean that no pure ldiskfs Server install is made during non zfs-reviews?
So since, I easily presume it will not be accepted to revert some of your changes from LU-4606 and switch-back to the method where libzfs is dlopen()'ed in mount_utils_zfs.c instead of being explicitely linked now nor to use, since Option 1 / 12538 has already been abandonned, you are again right there is only Option 3 / 12589 left, unless there is some other and better idea to fix?

[Nathaniel Clark]

Option 2 / 12550 causes a zfs dependency in the base lustre rpm, and I would think that that would cause large headaches for ldiskfs only sites.
Option 3 (seperate user-space rpms with the dso's) seems like the right answer

[Christopher Morrone (Inactive)]

Option 2, change 12550, seems like the best stop-gap measure as of version Patch Set 6. I marked it -1 but my quibbles are pretty minor and easily addressed.

Longer term, we really need to address some a bigger issue with this code, but it doesn't really need to be addressed in this ticket:

We shouldn't call osd_init() at all for client mounts. Better yet, maybe we should split the server mounts out into a separate mount command, e.g. mount.lustre_server. Or maybe even one for each osd type: mount.losd_zfs, mount.losd_ldiskfs.